856957 - [traceback] ValueError: Cannot assign None: "Review.addon" does not allow null values - users.views in get_addons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

http://sentry.dmz.phx1.mozilla.com/addons/addons/group/12708/

ValueError: Cannot assign None: "Review.addon" does not allow null values.

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "users/views.py", line 64, in wrapper
    return f(request, user, *args, **kw)
  File "users/views.py", line 594, in profile
    .transform(get_addons))
  File "django/db/models/query.py", line 87, in __len__
    self._result_cache.extend(self._iter)
  File "caching/base.py", line 102, in __iter__
    obj = iterator.next()
  File "caching/base.py", line 168, in fetch_by_id
    new = dict((byid(o), o) for o in others)
  File "django/db/models/query.py", line 100, in __iter__
    self._iter = self.iterator()
  File "caching/base.py", line 135, in iterator
    return iter(iterator())
  File "queryset_transform/__init__.py", line 22, in iterator
    fn(results)
  File "amo/decorators.py", line 149, in wrapper
    return f(*args, **kw)
  File "users/views.py", line 591, in get_addons
    review.addon = addons.get(review.addon_id)
  File "django/db/models/fields/related.py", line 362, in __set__
    (instance._meta.object_name, self.field.name))

Comment 1

[Christopher Van Wiemeersch [:cvan]]

WIP: https://github.com/mozilla/zamboni/commit/e522880

Needs tests

Comment 2

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/664d1c5

No additional tests needed since we already had some which I fortunately didn't break:

https://github.com/mozilla/zamboni/blob/master/apps/users/tests/test_views.py#L1142