Make create_talos_zip.py error out on Windows until we fix bug 829690

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
create_talos_zip.py is currently broken on Windows (it creates a talos.zip that fails when processing crashes; bug 829690) - so we should error out for now (until bug 829690 is fixed), to avoid other devs hitting it and wasting time figuring it out.
(Assignee)

Comment 1

6 years ago
Created attachment 732275 [details] [diff] [review]
Patch v1
Attachment #732275 - Flags: review?(jhammel)

Comment 2

6 years ago
Comment on attachment 732275 [details] [diff] [review]
Patch v1

LGTM, thanks for the patch!

I tend to put full bug URLs in code and would have used triple quotes for this but...not important
Attachment #732275 - Flags: review?(jhammel) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Jeff Hammel [:jhammel] from comment #2)
> I tend to put full bug URLs in code and would have used triple quotes for
> this but...not important

Triple quotes would have required processing before output to stderr due to linebreaks/whitespace etc, which is why I went for normal concatenated.

Thank you for the review :-)

https://hg.mozilla.org/build/talos/rev/f2eb8ccf9838
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.