857091 - [jsdbg2] Assertion failure: !cx->isExceptionPending(), at ../jscntxtinlines.h:341

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase asserts on mozilla-central revision aae004a3c5d9 (run with --ion-eager):


eval("(function() { " + "\
var otherGlobalSameCompartment = newGlobal('same-compartment');\
eval = otherGlobalSameCompartment.eval;\
" + " })();");
eval("(function() { " + "\
var dbg = new Debugger;\
assertEq(dbg.addAllGlobalsAsDebuggees(), undefined);\
" + " })();");

Comment 1

[Christian Holler (:decoder)]

JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   117593:2fce7807dc84
user:        Panos Astithas
date:        Fri Jan 04 21:34:43 2013 +0200
summary:     Implement a new addAllGlobalsAsDebuggees method for faster chrome debugging (bug 821701); r=jimb

This iteration took 142.171 seconds to run.

Comment 2

[Jim Blandy :jimb]

This also crashes for me, with no shell flags passed at all:
newGlobal('same-compartment')
.eval("assertEq((new Debugger).addAllGlobalsAsDebuggees(), undefined);");

Comment 3

[Jim Blandy :jimb]

Or, of course:
newGlobal().eval("assertEq((new Debugger).addAllGlobalsAsDebuggees(), undefined);");

Comment 4

[Jim Blandy :jimb]

Or even:
newGlobal().eval("(new Debugger).addAllGlobalsAsDebuggees();");

Comment 5

[Jim Blandy :jimb]

Attachment: Debugger: Don't ignore errors returned by dbg->addDebuggeeGlobal in addAllGlobalsAsDebuggees.

Original code was r=me...

Comment 6

[Jim Blandy :jimb]

https://tbpl.mozilla.org/?tree=Try&rev=944e285f64f0

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Ugh, sorry about that!

Comment 8

[Jim Blandy :jimb]

Failures on try are because the test requires an exception to be thrown --- but some tests run everything in debug mode, so there's no problem adding debuggees with live frames on the stack.

Comment 9

[Jim Blandy :jimb]

https://tbpl.mozilla.org/?tree=Try&rev=d57d42b0c84d

Comment 10

[Jim Blandy :jimb]

Comment on attachment 740508 [details] [diff] [review]
Debugger: Don't ignore errors returned by dbg->addDebuggeeGlobal in addAllGlobalsAsDebuggees.

All try failures are starred, or the test suite was re-run and resolved. Requesting review.

Comment 11

[Jim Blandy :jimb]

Attachment: Debugger: Don't ignore errors returned by dbg->addDebuggeeGlobal in addAllGlobalsAsDebuggees. r=jorendorff

Revised test to pass when the shell has put everything in debug mode, and thus the test case does not throw. Carrying over r=jorendorff.

Comment 12

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97663ef54fef

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97663ef54fef