Last Comment Bug 857116 - Remove nsIDOMHTMLCommandElement
: Remove nsIDOMHTMLCommandElement
Status: RESOLVED FIXED
: dev-doc-complete, site-compat
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla24
Assigned To: Andrea Marchesini [:baku]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 973412
  Show dependency treegraph
 
Reported: 2013-04-02 08:32 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2014-02-16 23:43 PST (History)
4 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (5.53 KB, patch)
2013-05-29 16:24 PDT, Andrea Marchesini [:baku]
Ms2ger: review+
Details | Diff | Splinter Review
m-c patch (5.56 KB, patch)
2013-06-06 05:15 PDT, Andrea Marchesini [:baku]
no flags Details | Diff | Splinter Review
inbound patch (5.54 KB, patch)
2013-06-06 06:05 PDT, Andrea Marchesini [:baku]
amarchesini: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2013-04-02 08:32:51 PDT
There is no such beastie in the spec.
Comment 1 Andrea Marchesini [:baku] 2013-05-29 16:23:31 PDT
https://tbpl.mozilla.org/?tree=Try&rev=3ec2d79414ac
Comment 2 Andrea Marchesini [:baku] 2013-05-29 16:24:38 PDT
Created attachment 755674 [details] [diff] [review]
patch
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2013-06-06 01:07:14 PDT
Comment on attachment 755674 [details] [diff] [review]
patch

Review of attachment 755674 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-06-06 05:01:21 PDT
Needs rebasing.
Comment 5 Andrea Marchesini [:baku] 2013-06-06 05:15:25 PDT
Created attachment 759079 [details] [diff] [review]
m-c patch
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-06-06 05:47:13 PDT
Did you rebase against inbound? Still hitting conflicts.
Comment 7 Andrea Marchesini [:baku] 2013-06-06 06:05:17 PDT
Created attachment 759093 [details] [diff] [review]
inbound patch

This patch is for mozilla-inbound
Comment 8 Ryan VanderMeulen [:RyanVM] 2013-06-06 06:30:13 PDT
err...

patching file content/html/content/src/HTMLMenuItemElement.cpp
Hunk #1 FAILED at 170
1 out of 1 hunks FAILED -- saving rejects to file content/html/content/src/HTMLMenuItemElement.cpp.rej
patching file content/html/content/src/HTMLMenuItemElement.h
Hunk #1 FAILED at 32
1 out of 1 hunks FAILED -- saving rejects to file content/html/content/src/HTMLMenuItemElement.h.rej
patching file dom/interfaces/html/nsIDOMHTMLCommandElement.idl
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file dom/interfaces/html/nsIDOMHTMLCommandElement.idl.rej
patching file dom/interfaces/html/nsIDOMHTMLMenuItemElement.idl
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file dom/interfaces/html/nsIDOMHTMLMenuItemElement.idl.rej
Comment 10 Ryan VanderMeulen [:RyanVM] 2013-06-06 12:28:42 PDT
https://hg.mozilla.org/mozilla-central/rev/e6b129e4eebc

Note You need to log in before you can comment on or make changes to this bug.