Closed Bug 857161 Opened 7 years ago Closed 7 years ago

Add flags to szip invocation on build slaves

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Since bug 848770, szip has an aggressive mode for compression, where it chooses the best size for dictionary size and filter automatically, but this makes compression significantly slower, which may get in the way of developers on local builds. So, use the default compression settings by default (heh), and allow the build slave mozconfigs to set the aggressive flags.
Depends on: 857151
Comment on attachment 732398 [details] [diff] [review]
Add aggressive flags to szip invocation on build slaves

Review of attachment 732398 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/config/mozconfigs/common
@@ +6,5 @@
>  
>  . "$topsrcdir/build/mozconfig.common"
> +
> +# Set the most aggressive settings for szip.
> +MOZ_SZIP_FLAGS="-D auto -f auto"

Might want to comment that this isn't the default because it's slower and we didn't want to slow down developer builds.
Attachment #732398 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/80026f1feb06
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.