857263 - [FHR] "Raw Data" view not displaying JSON

Status: RESOLVED WORKSFORME

(Firefox Health Report Graveyard :: Web: Health Report, defect, P2)

Description

[Dave Zeber [:dzeber]]

Attachment: fhr payload with errors

I have a profile whose health report got corrupted by manually copying from another installation. It has errors logged in the JSON and no startup time data, so no plot is displayed in about:healthreport (as expected). 

However, the JSON is still in valid format, but it is not shown in the Raw Data view (the space is just blank). The JSON should still be displayed.

Comment 1

[Daniel Einspanjer [:dre] [:deinspanjer]]

Providing initial triage, but I am not the final say.

Definitely something we should fix, but I'm okay with not blocking beta.

Comment 2

[Schalk Neethling [:espressive]]

Showing a message in the RAW JSON is doable but, displaying is not, as the JSON gets parsed and will throw an error. I suppose we can still display the broken JSON but, do we really want to? Instead I think we need to inform the user that the received data was invalid. Thoughts?

Comment 3

[Dave Zeber [:dzeber]]

In the case I was looking at, the payload was still a valid JSON object (which I thought should be parseable), but there was a problem with the amount and type of data that was present. The graph area was just blank with no message. My thought was that if I can look at the the raw JSON, at least I can try to understand what was happening. In this case, I opened the json file manually from my profile directory and saw that there were errors relating to appinfo. I thought it would be better if that could be displayed directly on the healthreport page.

Comment 4

[Georg Fritzsche [:gfritzsche]]

about:healthreport switched to using v4/Telemetry as a source, so this doesn't apply anymore.