857342 - Tab counter animation delayed until toolbar is visible again

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Cameron says:

--
When you open some tabs in  the background while the address bar is not shown (because you've  scrolled down the page), the animations to show the new number of tabs  is triggered when you scroll up a bit to reveal the address bar.  This  can be some time after the tabs were opened, so it seems a bit odd to  have the animation; it feels like it is saying that the tabs were just  opened, which isn't the case.
--

I can reproduce, and agree it looks wrong. Not sure if this is a sriram "animation" bug or a Cwiiis "dynamic toolbar" bug. Perhaps some collaboration is in order.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Is the expected behavior not to animate with the BrowserToolbar is hidden?

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I couldn't reproduce it. But here is a patch. If the browsertoolbar isn't visible or animating, we default to updateTabsCount() if even updateTabsCountAndAnimate() was called.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 732579 [details] [diff] [review]
Patch

Seems safe, but I'd like to get it verified.

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11bd7d1bbe0d

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I tested the patch locally and it worked fine.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/11bd7d1bbe0d

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Uplift?

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 732579 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Dynamic toolbar.
User impact if declined: The animation might happen when the browser toolbar is shown sometime later after open a tab in background.
Testing completed (on m-c, etc.): Landed in m-c on 04/03
Risk to taking this patch (and alternatives if risky): None. :P If the view isn't visible "y u animate?"
String or IDL/UUID changes made by this patch: None.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba4b5ba5492b

Comment 10

[Paul Feher]

Firefox for Android 23.0b2 (2013-07-02)
Device: LG Optimus 4x 
OS:Android 4.1.2