soft keyboard dims returned to content are logical coordinates

RESOLVED WORKSFORME

Status

Firefox for Metro
Input
RESOLVED WORKSFORME
5 years ago
3 years ago

People

(Reporter: jimm, Unassigned)

Tracking

Trunk
x86_64
Windows 8.1

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
I'm not sure what we should be returning here. 

http://mxr.mozilla.org/mozilla-central/source/widget/windows/winrt/FrameworkView.cpp#375

get_OccludedRect return device independent dims. These values get handed directly to front end code via a js interface - 

http://mxr.mozilla.org/mozilla-central/source/widget/nsIWinMetroUtils.idl#131

In the front end code we use these to do bounds calculations involving window dims.

I'm not sure what we return for properties like element.ownerDocument.defaultView.innerHeight, these values are smaller than physical coordinates but they probably are not Windows logical coordinates. I think they are mozilla css pixels, which might involve different conversion math.

Anyway, I'm trying to figure out what we should do with this OccludedRect rect data before it gets handed to front end code.

:jfkthame, curious if you might be able to offer some guidance here?
(Reporter)

Comment 1

5 years ago
Looks like these should remain as is, they appear to match the same dims we use in content. But curious where the conversion takes place. If physical coordinates are converted down to logical (maybe not Windows logical, not sure there) I'd like to find where that takes place to be sure we are treating these right.
(Reporter)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
(Assignee)

Updated

3 years ago
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.