[meta] B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager

RESOLVED FIXED

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: edgar, Unassigned)

Tracking

({dev-doc-needed})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(6 attachments)

(Reporter)

Description

5 years ago
To have a more clear design for mozMobileConnection and mozIccManager, we plan to move all icc/sim-related stuff from mozMobileConnection to mozIccManager as RIL developers have discussed in [1]. And also separate mozIccManager from mozMobileConnection. 

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=782603#c42
(Reporter)

Updated

5 years ago
Blocks: 843452
(Reporter)

Comment 1

5 years ago
To avoid breaking icc related function, I plan to add icc-related stuff into IccManager but keep mobileConnection API unchanged. I will file another bug for removing those deprecated stuff from MobileConnection after Gaia has applied this new design. Any other good suggestions? :)
(Reporter)

Comment 2

5 years ago
Created attachment 732752 [details] [diff] [review]
Part 1: Put icc related attribute and function into IccManager (IDL), v1
(Reporter)

Comment 3

5 years ago
Created attachment 732753 [details] [diff] [review]
Part 2: Put icc related attribute and function into IccManager (DOM), v1
(Reporter)

Comment 4

5 years ago
Created attachment 732757 [details] [diff] [review]
Part 3: GPS changes, v1
(Reporter)

Comment 5

5 years ago
Created attachment 732759 [details] [diff] [review]
Part 4: Bluetooth changes, v1
(Reporter)

Comment 6

5 years ago
Created attachment 732760 [details] [diff] [review]
Part 5: RIL implementation for new event of IccListener, v1
(Reporter)

Comment 7

5 years ago
Created attachment 732761 [details] [diff] [review]
Part 6: Marionette tests for IccManager, v1
Comment on attachment 732752 [details] [diff] [review]
Part 1: Put icc related attribute and function into IccManager (IDL), v1

Review of attachment 732752 [details] [diff] [review]:
-----------------------------------------------------------------

1.Please discuss with smaug first,
for he's concerns to put icc into navigator in the first place. See Bug 744714 Comment 75.

2. Please break your patches into smaller parts, or make it seperate bugs.
I hope you understand you're changing 'iccinfo', 'card lock', 'card state', 'call forwaring', and these 4 functionalities are heavily used dairy in dogfooding.

3. Remove 'Mobile' in MobileCFInfo, also I would suggest using CallForwardingInfo for a more detail name.
(Reporter)

Comment 9

5 years ago
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #8)
> Comment on attachment 732752 [details] [diff] [review]
> Part 1: Put icc related attribute and function into IccManager (IDL), v1
> 
> Review of attachment 732752 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> 1.Please discuss with smaug first,
> for he's concerns to put icc into navigator in the first place. See Bug
> 744714 Comment 75.
Ok, I will discuss with :smaug about the naming in navigator.

> 
> 2. Please break your patches into smaller parts, or make it seperate bugs.
> I hope you understand you're changing 'iccinfo', 'card lock', 'card state',
> 'call forwaring', and these 4 functionalities are heavily used dairy in
> dogfooding.
I will try to file separate bug.

> 
> 3. Remove 'Mobile' in MobileCFInfo, also I would suggest using
> CallForwardingInfo for a more detail name.
Good suggestion, thanks
(Reporter)

Updated

5 years ago
Depends on: 859220
(Reporter)

Updated

5 years ago
Depends on: 860585
(Reporter)

Updated

5 years ago
Summary: B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager → [meta] B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager
(Reporter)

Updated

5 years ago
Depends on: 861083
(Reporter)

Updated

5 years ago
Blocks: 864489
(Reporter)

Updated

5 years ago
Depends on: 874744
(Reporter)

Updated

5 years ago
Depends on: 875710
(Reporter)

Updated

5 years ago
Depends on: 875721
Keywords: dev-doc-needed
(Reporter)

Updated

5 years ago
Assignee: echen → nobody
(Reporter)

Updated

5 years ago
Depends on: 886239
(Reporter)

Comment 10

5 years ago
All bugs are RESOLVED, we could close this meta bug. :)
Thanks, everyone!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.