Closed Bug 857414 Opened 7 years ago Closed 7 years ago

[meta] B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: edgar, Unassigned)

References

Details

(Keywords: dev-doc-needed)

Attachments

(6 files)

To have a more clear design for mozMobileConnection and mozIccManager, we plan to move all icc/sim-related stuff from mozMobileConnection to mozIccManager as RIL developers have discussed in [1]. And also separate mozIccManager from mozMobileConnection. 

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=782603#c42
To avoid breaking icc related function, I plan to add icc-related stuff into IccManager but keep mobileConnection API unchanged. I will file another bug for removing those deprecated stuff from MobileConnection after Gaia has applied this new design. Any other good suggestions? :)
Comment on attachment 732752 [details] [diff] [review]
Part 1: Put icc related attribute and function into IccManager (IDL), v1

Review of attachment 732752 [details] [diff] [review]:
-----------------------------------------------------------------

1.Please discuss with smaug first,
for he's concerns to put icc into navigator in the first place. See Bug 744714 Comment 75.

2. Please break your patches into smaller parts, or make it seperate bugs.
I hope you understand you're changing 'iccinfo', 'card lock', 'card state', 'call forwaring', and these 4 functionalities are heavily used dairy in dogfooding.

3. Remove 'Mobile' in MobileCFInfo, also I would suggest using CallForwardingInfo for a more detail name.
(In reply to Yoshi Huang[:allstars.chh][:yoshi] from comment #8)
> Comment on attachment 732752 [details] [diff] [review]
> Part 1: Put icc related attribute and function into IccManager (IDL), v1
> 
> Review of attachment 732752 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> 1.Please discuss with smaug first,
> for he's concerns to put icc into navigator in the first place. See Bug
> 744714 Comment 75.
Ok, I will discuss with :smaug about the naming in navigator.

> 
> 2. Please break your patches into smaller parts, or make it seperate bugs.
> I hope you understand you're changing 'iccinfo', 'card lock', 'card state',
> 'call forwaring', and these 4 functionalities are heavily used dairy in
> dogfooding.
I will try to file separate bug.

> 
> 3. Remove 'Mobile' in MobileCFInfo, also I would suggest using
> CallForwardingInfo for a more detail name.
Good suggestion, thanks
Depends on: 859220
Depends on: 860585
Summary: B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager → [meta] B2G RIL: Move all icc/sim-related stuff from mozMobileConnection to mozIccManager
Depends on: 861083
Depends on: 874744
Depends on: 875710
Depends on: 875721
Assignee: echen → nobody
Depends on: 886239
All bugs are RESOLVED, we could close this meta bug. :)
Thanks, everyone!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.