857451 - Breakpoints not working in browser debugger

Status: RESOLVED WORKSFORME

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

This still seems to be happening.

STR:
1. Open/close normal debugger
2. Open browser debugger
3. Add breakpoint in debugger-controller.js DC_initialize (or DC_startupDebugger)
4. Open normal debugger

Nothing happens.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

In this case we set a breakpoint in a script that will only get triggered after we restart the debugger, causing a different instance of the script to load. The bug must be somewhere in the breakpointStore-related logic in TA_setBreakpoint. It may be related to bug 851836 (which is a regression from bug 820012).

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

We only restore a breakpoint if it isn't already attached to a script. Not completely sure why though...

http://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/actors/script.js#2263

Comment 3

[Axel Grude [:realRaven]]

I can reproduce this bug when remote debugging my Addon quickFilters on Thunderbird. I have code which is in the filter editor overlaying 
http://http://mxr.mozilla.org/comm-central/source/mailnews/base/search/content/FilterEditor.xul

This window is usually shown as a child window from the Filter List dialog, so this is no direct child of the main Thunderbird (3-pane) window. All sources are displayed but all breakpoints (and debugger statements) are ignored. When the window opens I can detect a change in the js-files list on the left hand side, but I do not know what changes.

The window is modeless.

Comment 4

[Eddy Bruel [:ejpbruel]]

I will take another look at this bug when I get back from vacation. If anybody else wants to take a look at this in my absence, just shoot me an e-mail.

Comment 5

[David Walsh :davidwalsh]

We've been reliably debugging the new debugger for a while.