857574 - Contacts app takes long time the first time to enter in search mode when the list is already loaded

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Cristian Rodriguez (:crdlc)]

STR:

Requirements: 500 contacts 

1) Open the contacts app 
2) Wait until the list is completely loaded
3) Click on search box

Expected: app enters in search mode faster

Actual: you don't enter in search mode with the first click. If you click again, you wait a couple of seconds

----------

If you open the contacts app and don't wait for the load of the list, you enter in search mode fast

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 732832 [details]
Patch v1

Tried with 2000 contacts and works pretty well.

:)

Great job Cristian.

Comment 3

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/29660ec0a4ad7c90d22e33852e1601d45f781e03

Comment 4

[Cristian Rodriguez (:crdlc)]

Important: this bug should be uplifted to v1.0.1 after bug 857925

Comment 6

[Jeni]

Verfied fixed on 


Unagi Build ID: 20130409070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/cfef36c0c8bc
Gaia: a80be95f553de517e5d8a159e04511cda5e38be4

When searching for a name in contacts it shows right as you type the letter.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 29660ec0a4ad7c90d22e33852e1601d45f781e03
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train)

Comment 8

[Cristian Rodriguez (:crdlc)]

v1-train

https://github.com/mozilla-b2g/gaia/commit/3a626ff021a78a1da3e6a2000534156a4ea81fe1

Comment 9

[Cristian Rodriguez (:crdlc)]

v1.0.1

https://github.com/mozilla-b2g/gaia/commit/f9bb82c45fed37cf73ae56d75c2589a2fa33ef73

Comment 10

[Jeni]

Verified fixed on 

Unagi Build ID: 20130411070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/f83d169babee
Gaia: 81cab0e96c0064b03db46a5248047fed617c2f26

and on 

Unagi Build ID: 20130411070205
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66

When searching for a name in contacts it shows right as you type the letter.