857652 - XPCShellEnvironment's 'quit' doesn't ask event loop to quit

Status: RESOLVED WONTFIX

(Core :: IPC, defect)

Description

[Jim Blandy :jimb]

Attachment: Make XPCShellEnvironment's 'quit' work when called from an observer or an nsIMessageListener.

ipc/testshell/XPCShellEnvironment.cpp's 'Quit' function relies on throwing a termination (an error with no JavaScript exception set) to exit the process, but things like observers and nsIMessageListeners get called in places that ignore errors.

XPCShellEnvironment's 'quit' should call XRE_ShutdownChildProcess, to properly ask the child's event loop to stop running.

Patch coming up; will r? if try likes it.

Comment 1

[Jim Blandy :jimb]

https://tbpl.mozilla.org/?tree=Try&rev=0dee616103f4

Comment 2

[Jim Blandy :jimb]

Here's an interesting failure. Looks like the new tests don't work too well on B2G.

https://tbpl.mozilla.org/?tree=Try&rev=0dee616103f4&jobname=b2g_ics_armv7a_gecko_emulator_vm%20try%20opt%20test%20xpcshell

Comment 3

[Jim Blandy :jimb]

This one as well:

https://tbpl.mozilla.org/?tree=Try&rev=0dee616103f4&jobname=Rev3%20WINNT%205.1%20try%20opt%20test%20xpcshell

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Jim Blandy :jimb from comment #3)
> This one as well:
> 
> https://tbpl.mozilla.org/?tree=Try&rev=0dee616103f4&jobname=Rev3%20WINNT%205.
> 1%20try%20opt%20test%20xpcshell

The Windows failures look like known oranges, no? Bug 855757 and bug 824022?

Comment 5

[Jim Blandy :jimb]

(In reply to Panos Astithas [:past] from comment #4)
> The Windows failures look like known oranges, no? Bug 855757 and bug 824022?

Yes, I think that's right.

Comment 6

[Jim Blandy :jimb]

With the patch in bug 874755, we may not need XPCShellEnvironment at all any more, so working on XPCShellEnvironment is probably not worth it.