857687 - Supplementary Services responses are shown in English when device is in Spanish

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Beatriz Rodríguez [:brg]]

Supplementary Services responses are shown in English, although Spanish language is selected. It can be checkd by code just checking the status of CFU (*#21#)

Steps to Reproduce:    
- Set language to Spanish    
- Checking the status of CFU (*#21#) or CW (*#43#)

Actual Result
The response will be shown in English

Expected Result:
It should be shown in Spanish   

Buildid "20130321070205", device: ikura

Comment 1

[Julien Wajsberg [:julienw]]

In my test (in france), I find that, whether the language is french or english, I get :

* the answer in french
* the "send" button in english

I tried then with the same SIM card on my Android phone, and the answer is also in french even if my phone is configured in english.

So is this bug only about the "send" button and maybe the title for the answer ?

Comment 2

[Julien Wajsberg [:julienw]]

I know :rik is currently working on USSD so Ccing him here.

Comment 3

[Beatriz Rodríguez [:brg]]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> In my test (in france), I find that, whether the language is french or
> english, I get :
> 
> * the answer in french
> * the "send" button in english
> 
> I tried then with the same SIM card on my Android phone, and the answer is
> also in french even if my phone is configured in english.
> 
I tried with the same SIM card and an Android device in Spanish and the response was in Spanish. And the response to the user has different information!
So I guess that the response from the NW is not properly translated for Spanish language, I think this issue as L10n and adding Stas in CC and needinfo.

> So is this bug only about the "send" button and maybe the title for the
> answer ?
Agree with the "Send" button, it is always in English.

Comment 4

[Julien Wajsberg [:julienw]]

I really don't think we can generally translate what comes back from the network... But maybe there is a "flag" to set when sending the USSD ?

(note: I tried using #123# in the dialer, #123# is used to get the balance information)

Comment 5

[Anthony Ricaud (:rik)]

Actually, those are the only messages that we translate. So this is an L10N issue.

See https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/ussd.js#L105

Comment 6

[Beatriz Rodríguez [:brg]]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> I really don't think we can generally translate what comes back from the
> network... But maybe there is a "flag" to set when sending the USSD ?
> 
> (note: I tried using #123# in the dialer, #123# is used to get the balance
> information)
You can try with the Suplementary service codes for checking the status of Call forwarding (*#21#) or Call Waiting (*#43#)

(In reply to Anthony Ricaud (:rik) from comment #5)
> Actually, those are the only messages that we translate. So this is an L10N
> issue.
> 
> See
> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/
> js/ussd.js#L105
Thanks a lot!

Comment 7

[David Palomino [:dpalomino]]

Changing prio to P1, as this is a certification blocker.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Beatriz Rodríguez [:brg] from comment #0)
> Supplementary Services responses are shown in English, although Spanish
> language is selected. It can be checkd by code just checking the status of
> CFU (*#21#)
> 
> Steps to Reproduce:    
> - Set language to Spanish    
> - Checking the status of CFU (*#21#) or CW (*#43#)
> 
> Actual Result
> The response will be shown in English
> 
> Expected Result:
> It should be shown in Spanish   
> 
> Buildid "20130321070205", device: ikura

As far as I can see, there are no Spanish locales for the dialer.

See https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/dialer/locales

(In reply to Julien Wajsberg [:julienw] from comment #4)
> I really don't think we can generally translate what comes back from the
> network... But maybe there is a "flag" to set when sending the USSD ?
> 

We can't. And there is no such flag. USSD messages usually arrive translated to the language corresponding to the MCC. In any case, what you are testing is an USSD and the bug reports the usage of an MMI code (for Call Forwarding requests). MMI replies coming from the device should be localized.


(In reply to Beatriz Rodríguez [:brg] from comment #6)
> (In reply to Julien Wajsberg [:julienw] from comment #4)
> > I really don't think we can generally translate what comes back from the
> > network... But maybe there is a "flag" to set when sending the USSD ?
> > 
> > (note: I tried using #123# in the dialer, #123# is used to get the balance
> > information)
> You can try with the Suplementary service codes for checking the status of
> Call forwarding (*#21#) or Call Waiting (*#43#)

There is no support for querying the Call Waiting status via MMI as I've been told (by you :P) that it was not a certification requirement.

Comment 9

[Julien Wajsberg [:julienw]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #8)
> 
> As far as I can see, there are no Spanish locales for the dialer.
> 
> See
> https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/dialer/
> locales

The locales have their very own repository in http://hg.mozilla.org/gaia-l10n ;)

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> (In reply to Fernando Jiménez Moreno [:ferjm] from comment #8)
> > 
> > As far as I can see, there are no Spanish locales for the dialer.
> > 
> > See
> > https://github.com/mozilla-b2g/gaia/tree/master/apps/communications/dialer/
> > locales
> 
> The locales have their very own repository in
> http://hg.mozilla.org/gaia-l10n ;)

Ok, I see, thanks. It seems that the locales are there http://hg.mozilla.org/gaia-l10n/es/file/0fc4d28a3269/apps/communications/dialer/dialer.properties#l9

Comment 11

[Daniel Coloma:dcoloma]

This is working in Unagi with v1.0.1 both in Spanish and Portuguese (except the send button issue already mentioned).

Can our partners check with a more recent build to check if this has been resolved already?

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Daniel Coloma:dcoloma from comment #11)
> This is working in Unagi with v1.0.1 both in Spanish and Portuguese (except
> the send button issue already mentioned).
> 
> Can our partners check with a more recent build to check if this has been
> resolved already?

Since you says it works I'm going to close this bug as WFM and it can be reopened if it still happens.

Comment 13

[Beatriz Rodríguez [:brg]]

Tested today using Unagi v1.0.1, the information is provided in Spanish if you are using Moz RIL however it is offered in English if you change to Commercial RIL.

I reopen the bug because it is a certification blocker.

Comment 14

[Anshul]

The supplementary services information is always provided in English and it does seem like an issue with commercial RIL. I will be working on it shortly.

Comment 15

[Anshul]

Beatriz/dpv, so even with Moz RIL only the call forwarding message is shown in spanish. If there is an error in setting call forwarding, the error message is shown in english and not spanish. Commercial RIL supports lot more supplemental services then Moz RIL and so for all those we can not internationalize as https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/ussd.js doesn't support internationalizing anything but call forwarding. 

So to me it seems like all of the supplemental services can not be internationalized at this point. I can add support for internationalizing the call forwarding only for commercial RIL but everything else would be still in English. 

Also, commercial RIL provides more meaningful information when say CFU is being set such as "call forwarding is now enabled" while moz RIL just says "message sent". I can fix that as well in commercial RIL as "message sent" can also be internationalized but that is not a very descriptive information to the user.

Let me know what you guys think?

Comment 16

[Michael Vines [:m1] [:evilmachines]]

(clearing out some, what appear to now be, stale ni?s)

Comment 17

[Anshul]

These supplemental services are not really used by end users as such and with inconsistency between some information in a different language and some in english I am debating if this needs to be fixed in commercial RIL until we add support for internatiolizing all possible responses for all possible supplemental services in gaia.

All the error messages currently are displayed in English even with Moz RIL and for rest of the supplemental services that Moz RIL doesn't support commercial RIL will have no way to internationalize them. 

So as of now, all I can do is to only internationalize the query call forwarding result and leave everything else in english.

Comment 18

[Julien Wajsberg [:julienw]]

I think the 'message sent' message is being removed, or at least reworked, in Bug 853798, by :rik.

Comment 19

[Beatriz Rodríguez [:brg]]

(In reply to Anshul from comment #15)
> Beatriz/dpv, so even with Moz RIL only the call forwarding message is shown
> in spanish. If there is an error in setting call forwarding, the error
> message is shown in english and not spanish. Commercial RIL supports lot
> more supplemental services then Moz RIL and so for all those we can not
> internationalize as
> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/
> js/ussd.js doesn't support internationalizing anything but call forwarding. 
> 
> So to me it seems like all of the supplemental services can not be
> internationalized at this point. I can add support for internationalizing
> the call forwarding only for commercial RIL but everything else would be
> still in English. 
We know that we only support CF SS and we want to have the messages translated to Spanish as much as possible so please implement this translation in the commercial RIL as well. 
> Also, commercial RIL provides more meaningful information when say CFU is
> being set such as "call forwarding is now enabled" while moz RIL just says
> "message sent". I can fix that as well in commercial RIL as "message sent"
> can also be internationalized but that is not a very descriptive information
> to the user.
> 
> Let me know what you guys think?
Adding jaoo here to clarify the implementation in Mozilla RIL.

(In reply to Anshul from comment #17)
> These supplemental services are not really used by end users as such and
> with inconsistency between some information in a different language and some
> in english I am debating if this needs to be fixed in commercial RIL until
> we add support for internatiolizing all possible responses for all possible
> supplemental services in gaia.
> 
> All the error messages currently are displayed in English even with Moz RIL
> and for rest of the supplemental services that Moz RIL doesn't support
> commercial RIL will have no way to internationalize them. 
Other supplementary services will be included in future releases and there are other bugs already open to implement them. So lets take care of them in the future.

> So as of now, all I can do is to only internationalize the query call
> forwarding result and leave everything else in english.
Please implement this and we will follow the other responses in a different bug.
(In reply to Julien Wajsberg [:julienw] from comment #18)
> I think the 'message sent' message is being removed, or at least reworked,
> in Bug 853798, by :rik.
We reported here that the "Send" label is always in English (differnt to bug 853798 topic) please let me know if you need a new bug to follow up this label issue.

Comment 20

[Juan Perez-Bedmar [:juanpbf]]

Adding some colleagues in CC

Comment 21

[Anshul]

Beatriz, yes please file a separate bug to internationalize the send label on the button as that needs to be done by Gaia and not commercial RIL.

Also, I don't see where in bug 853798 the "mmi-successfully-sent=Message successfully sent" is being reworked or removed.

Comment 22

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Anshul from comment #21)
> Beatriz, yes please file a separate bug to internationalize the send label
                             ^^^^^^^^^^^^
Has this bug been created?

Comment 23

[Beatriz Rodríguez [:brg]]

(In reply to Milan Sreckovic [:milan] from comment #22)
> (In reply to Anshul from comment #21)
> > Beatriz, yes please file a separate bug to internationalize the send label
>                              ^^^^^^^^^^^^
> Has this bug been created?

Yes, here it is bug 860292.

Comment 24

[David Palomino [:dpalomino]]

Also reported in LatAm, adding dep.

Comment 25

[Anshul]

David, I can't access bug 855322 and bug 855378, please add me to the CC list. I have finished adding support for this bug in commercial RIL and would let you know as soon as a AU is available.

Comment 26

[Daniel Coloma:dcoloma]

(In reply to Anshul from comment #25)
> David, I can't access bug 855322 and bug 855378, please add me to the CC
> list. I have finished adding support for this bug in commercial RIL and
> would let you know as soon as a AU is available.

you should have access to those bugs now

Comment 27

[Staś Małolepszy :stas]

Clearing the needinfo on me, as it seems that the root cause has been found.

(In reply to Anshul from comment #21)
> Beatriz, yes please file a separate bug to internationalize the send label
> on the button as that needs to be done by Gaia and not commercial RIL.

There's bug 859105 about this too, I duped the one Beatriz filed.

Comment 28

[Anshul]

The issue is fixed in AU_LINUX_GECKO_ICS_STRAWBERRY_V1.01.00.01.19.073 that should be available later tonight PST.

Note that only the Call forwarding, PIN MMI and USSD codes are internationalized. Every other supplemental services supported by commercial RIL would still be in English as there is no Gaia interface available yet.

Comment 29

[José Antonio Olivera Ortega [:jaoo]]

Is this issue still happening without using shipping RIL?

Comment 30

[José Antonio Olivera Ortega [:jaoo]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #29)
> Is this issue still happening without using shipping RIL?

Well, I needed to read all the comments here. Since the support of supplementary services is limited to call forwarding feature with Moz RIL and the UI is -more or less- translate to Spanish there is no anything to do here in the Moz RIL/ Gaia implementation. Let me know guys if translating the error message in case of error while setting up call forwarding (what Anshul commented in comment #15) blocks or not. I'll be happy to work on it.

Comment 31

[Delphine Lebédel [:delphine - Use needinfo]]

Still an issue on Commercial RIL v1.0.1 from 04/22, on Inari device:
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
BuildID 20130422054646
Version 18.0

Tried both in Spanish and pt-BR: Cancel Button is in English ("sending" appears translated). Answer is in English as well. The rest appears translated.

Not sure if supposed to reopen or not from comments...

Comment 32

[Anshul]

Delphine, could you please let me know which AU you are using and also provide the android logs?

Comment 33

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9376

Pointer to Github pull-request

Comment 34

[Anthony Ricaud (:rik)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9376#attch-to-bugzilla

Pointer to Github pull-request

Comment 35

[Anthony Ricaud (:rik)]

This PR only solves the cancel button being in English.

Comment 36

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/3ae01fd39341c97be953ac3bc5c5902ee9e6d6ed on master. I'll uplift this myself.

Comment 37

[Anthony Ricaud (:rik)]

v1-train: c3a710371e046cbb03e3447f18aa5785ec753d4e
v1.0.1: 42dad2d9a6026032f83897ae16caaf4719813a5d

Comment 38

[Delphine Lebédel [:delphine - Use needinfo]]

Fixed for when checking the status of CFU (*#21#): everything in answer is translated

However when I check status of CW (*#43#) the answer I get is in English: call waiting not supported via MMI

Comment 39

[Anshul]

Delphine, could you please share the android main logs and the radio logs by running the following command? Please also let me know which AU you are using.

adb logcat -b radio -b main -v time > logs.txt

Call waiting is not supported by Gaia yet and is not scoped for 1.0. However commercial RIL supports it and since there is no support in Gaia yet the messages in english are generated by commercial RIL and are not internationalizable.

Comment 40

[Delphine Lebédel [:delphine - Use needinfo]]

Attachment: logs.txt

Comment 41

[Delphine Lebédel [:delphine - Use needinfo]]

Sorry, didn't see that you were asking me something more here (better to use needinfo if you really need an answer quickly from me ;) )

Ok so testing with today's v1.0.1 Commercial RIL: 
* checking the status of CFU (*#21#): everything in answer is translated
* status of CW (*#43#) the answer is in English (but from what I understand from your comment 39 that is normal behavior at this point): "Call waiting, service has been disabled"

Please find the logs attached.
What do you mean by which AU am I using?

Comment 42

[John Hammink]

Reopening this, as I'm seeing the same results as Delphine.

Comment 43

[Anshul]

John, not sure why you opened the bug. As I have said in comment#28 that call waiting is not supported by Moz RIL and by gaia so the result of call waiting can not be translated into other languages besides english right now. Besides, call waiting is not even scoped for 1.0.

Comment 44

[John Hammink]

I'm on the 4/26 partner build - candidate for round 2 of certification.   

Gaia   a3176dbb57dd73fe99397392bf1f8a98a6bf66dd
BuildID 20130426165758
Version 18.0

Comment 45

[John Hammink]

It was a certification issue, and I understood it was one that needed to be fixed for the product to pass certification in Latam  David Palomino can have the last word on this.

Comment 46

[John Hammink]

Also I'm on the partner build so, and I am actually running on the Commercial RIL.

Comment 47

[Michael Vines [:m1] [:evilmachines]]

What AU # is the 4/26 partner build based on?

Comment 48

[Andrew Overholt [:overholt]]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #47)
> What AU # is the 4/26 partner build based on?

ni?(John)

Comment 49

[Daniel Coloma:dcoloma]

I think it is V1.01.00.01.19.087

Comment 50

[Andrew Overholt [:overholt]]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #47)
> What AU # is the 4/26 partner build based on?

(In reply to Daniel Coloma:dcoloma from comment #49)
> I think it is V1.01.00.01.19.087

Anshul/Michael, do you need more info to go on?

Comment 51

[Michael Vines [:m1] [:evilmachines]]

Please check out comment 43.  We need Gaia support to l10n these strings.

Comment 52

[Joe Cheng [:jcheng] (please needinfo)]

are we seriously blocking on translations of this? which is probably not that user facing either.

(In reply to delphine from comment #41)
> * status of CW (*#43#) the answer is in English (but from what I understand
> from your comment 39 that is normal behavior at this point): "Call waiting,
> service has been disabled"
>

Comment 53

[David Palomino [:dpalomino]]

Hi Joe, 

This was originally reported as a blocking issue by the carrier. I think we should try to solve this, if possible. 

Thanks, 
David

Comment 54

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #51)
> Please check out comment 43.  We need Gaia support to l10n these strings.

ni? [e-mail]

Comment 55

[Axel Hecht [:Pike]]

To be frank, I have no idea what the ask is. This does sound like an fx os engineering task, though. And I don't understand enough to say where in the stack it would be.

Comment 56

[Anshul]

David, let me try to explain once more.

1. Gaia/Moz RIL currently doesn't support any MMI codes besides call forwarding, PIN commands and USSD. All these can already be internationalized by commercial RIL. However the error messages for all of these can not be internationalized by both Moz RIL or commercial RIL because of the missing Gaia support.

2. Rest of the supplemental services (including call waiting) supported by commercial RIL can not be internationalized due to missing Gaia support. This can be added and I can work on it but it won't be a trivial change and wondering if this is really blocking for TEF?

Comment 57

[Johnny Stenback (:jst)]

Daniel will check on whether this really is a tef blocker and get back on Monday (5/13).

Comment 59

[Anshul]

Daniel, any update?

Comment 60

[Daniel Coloma:dcoloma]

Not 100% confirmed yet, but it seems that we have now should be enough for 1.0.1. David can provide final confirmation on Monday.

Comment 61

[John Hammink]

This issue has been (mostly) solved. Main error case is no longer reproducible. 

The bug this one blocks, khepera_43285, is resolved, fixed; not closing yet however until we're satisified across the board that this is fixed for both Spain and Columbia.

Comment 62

[Joe Cheng [:jcheng] (please needinfo)]

triage with tef: original bug is resolved. mark this as fixed. create a follow up to track the CW (*#43#) bug. Bug 873999 - Supplementary Services responses are shown in English when device is in Spanish (status of CW (*#43#))

Comment 63

[David Palomino [:dpalomino]]

Hi, 

Answering ni (sorry for the delay) Yes, it was enough for certification purposes. 

Thanks!
David