857720 - Support a way to capture the audio output sent to cubeb in debug builds

Status: RESOLVED DUPLICATE of bug 727697

(Core :: Audio/Video, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

I've found this patch extremely helpful when I'm trying to view what Firefox plays back in Audacity.  Perhaps it's worth checking it in.

Comment 1

[Matthew Gregan [:kinetik]]

Comment on attachment 732970 [details] [diff] [review]
Patch (v1)

You're the second person to ask for this, so I think we should check something in (and I was wrong before trying to talk roc out of it).  roc has a slightly fancier patch in bug 727697 that writes a WAVE header at the start of the file and deals with multiple active audio streams.

Comment 2

[Ralph Giles (:rillian)]

Indeed. Please write a WAV header if you're not going to use roc's patch.

Comment 3

[(no longer active)]

(In reply to comment #1)
> You're the second person to ask for this, so I think we should check something
> in (and I was wrong before trying to talk roc out of it).  roc has a slightly
> fancier patch in bug 727697 that writes a WAVE header at the start of the file
> and deals with multiple active audio streams.

Indeed, roc's patch is much fancier.  So, shall we just land it?  I don't think my patch has any advantages compared to roc's...  (Well it gives you control over where the file is being written, but cwd works just as fine for me.)

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 732970 [details] [diff] [review]
Patch (v1)

Sounds good, I'll dupe this bug.