Closed Bug 857816 Opened 9 years ago Closed 9 years ago

NativeWindow.menu's remove should be able to remove a submenu

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: sriram, Assigned: sriram)

References

Details

Attachments

(1 file)

Currently addons can remove a menuitem by id. However they cannot remove a sub menu item. This because our custom menu doesnt look into submenu to remove it. We should either enhance custom menu to look into sub menus and remove it, or supply a parameter with NativeWindow.menu.remove() that specifies the parent menu id.
Attached patch PatchSplinter Review
This removes the menu item from a submenu.
Attachment #733070 - Flags: review?(mark.finkle)
Blocks: 884340
Comment on attachment 733070 [details] [diff] [review]
Patch

Looks OK. The relationship between GeckoMenu and SubMenu is a little confusing.
Attachment #733070 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/342b14e63229
Assignee: nobody → sriram
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.