Closed Bug 857846 Opened 10 years ago Closed 10 years ago

Assertion failure: args[idxi].isInt32(), at vm/SelfHosting.cpp:366

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: decoder, Assigned: shu)

Details

(Keywords: assertion, testcase, Whiteboard: [jsbugmon:update])

Attachments

(1 file)

The following testcase asserts on mozilla-central revision 97cfc16ba5dc (no options required):


x = 0;
(x /= -9)
var len = 1024;
function add1(x) { return x+1; }
function id() { return x; }
var p = new ParallelArray(len, add1);
var revidx = build(len, id).reverse();
var r = p.scatter(revidx, 0, undefined, len, {});
function build(n, f) {
  var result = [];
  result.push(f(0));
  return result;
}
CC-ing Shu and Niko, as I'd bet considerable amounts on one of them ending up fixing this.
Thanks, you were faster than me :D
Whiteboard: [jsbugmon:update,bisect]
Attached patch fixSplinter Review
-0 | 0 === 0, but -0 isn't an int32.
Assignee: general → shu
Attachment #733155 - Flags: review?(nmatsakis)
Whiteboard: [jsbugmon:update,bisect] → [jsbugmon:update]
JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   125555:b00eb1ef1517
user:        Nicholas D. Matsakis
date:        Tue Mar 19 22:12:27 2013 -0400
summary:     Bug 829602 - Enable self-hosted parallelarray r=dvander,till

This iteration took 0.988 seconds to run.
Comment on attachment 733155 [details] [diff] [review]
fix

Review of attachment 733155 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, but I'm not sure if this is the right way to handle the situation.  It seems mildly inconsistent with arrays. For example:

    [22, 23, 24][-0] === 22

whereas your change will throw an error.  Also, whatever we decide, I imagine we'll need similar changes to all the places in ParallelArray where we check for integer-ness.

Giving r- for now until we settle on the path.
Attachment #733155 - Flags: review?(nmatsakis) → review-
Attachment #733155 - Flags: review- → review+
Never mind, in my previous comments I misinterpreted the patch.  It is in fact doing what I think we should be doing.
https://hg.mozilla.org/mozilla-central/rev/273c69918d05
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.