857885 - [Bluetooth]Seems to dot in the device image.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[leo.bugzilla.gecko]

Hi, Shawn

Seems to dot in the device images.

Seems to crop an image next to the image far as spots caused me.
I'll send a screenshot by e-mail.

thanks.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Do you mind share version information? I've tried to use leo device but seems no "spots" like you encounter. Can you share both gecko and gaia version? Thanks a lot.

Comment 2

[leo.bugzilla.gecko]

instead of the BT team of leo.bugzill.gecko, 
i am share version information.

buildid: "20130331070203"
gecko : revision="0b83d5e6a54df9bfccdbb5ba662527bf657f5381"
gaia : revision="5a1ead9c8f831167fd86464d21eea310c7082112"

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Since this is about UI, needs Evelyn to comment.

Comment 4

[leo.bugzilla.gecko]

Attachment: dot is showing in phone,printer of cod image

Comment 5

[leo.bugzilla.gecko]

Attachment: patch for icon size

Dear Mozilla Team,

I have modified this bug.
Please check your model and review this code.

Thanks.

Comment 6

[Dylan Oliver [:doliver]]

This issue was identified as a Leo QE1 blocker. Nominating for leo?

Comment 7

[Dylan Oliver [:doliver]]

Leo, can you please create a pull request attachment with your patch and ask Shawn or Evelyn for review?

Comment 8

[leo.bugzilla.gecko]

Attachment: Patch URL to pull request 9224

Comment 9

[leo.bugzilla.gecko]

Dear Mozilla Team,

I update the patch url.
Please review this.

Thanks.

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Comment on attachment 738355 [details] [diff] [review]
Patch URL to pull request 9224

Change review owner to Evelyn

Comment 11

[Evelyn Hung]

Comment on attachment 738355 [details] [diff] [review]
Patch URL to pull request 9224

I can't reproduce the issue on my leo device, redirect review request to Arthur because he is good at CSS.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 738355 [details] [diff] [review]
Patch URL to pull request 9224

I checked the sprite image and found that icons were placed in 30x30 grids perfectly. The issue may be related to sampling. However, I cannot reproduce it on my leo device, either. We need QA to verify this issue.

Regarding the pull request, there are two commits for different bugs in it. Please remove the unnecessary commit.

Comment 13

[Marcia Knous [:marcia]]

I am unable to reproduce this issue on my Leo device as well, Mozilla RIL using:

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/6a187d801193
Gaia   7ea7918013a012ddf04a1324592b898530488178
BuildID 20130423070204
Version 18.0

Comment 14

[leo.bugzilla.gecko]

Dear Mozilla Team,

I have confirmed that this bug is modified in latest gaia git.
Root cause is that different from our image (bluetooth_sprite.png).
I want to close this case.

Thanks.