85792 - Delete Cert dialogs need to be differentiated, text cleaned up

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P2)

Description

[Sean Cotter]

When you click the Delete button on any Cert Mgr tab, you see this text:

-------
You have requested to delete this certificate:

[cert subject name]

Are you sure you want to delete this certificate?
-------

This is a regression from PSM 1.x, which told you something about the 
consequences 
of deleting whatever kind of cert was involved. In addition, it makes no 
allowance for selecting multiple certs (only the first one shows up).

To match 1.x, some of the text needs to vary depending what kinds of certs you 
are trying to delete. 

In addition to the text changes described below, the dialog should list all 
certs that the user selected before clicking Delete.

Ideally, the title of the dialog should indicate what kind of cert is being 
deleted: Delete Your Certificate, Delete Web Site Certificate, or Delete CA 
Certificate. If this is too difficult, "Delete Certificates" would be OK for all 
three kinds of deletes. (Currently, the title of the dialog is the subject name 
of the cert, which doesn't hold up for multiple selections.)

Otherwise, I recommend that the text for each version look like this:

****Delete Your Certificates

Are you sure you want to delete these certificates?

[list of subject names]

If you delete one of your own certificates, you can no longer use it to identify 
yourself.

****Delete Web Site Certificates

Are you sure you want to delete these web site certificates?

[list of subject names]

If you delete a web site certificate, you will be asked to accept it again the 
next time you visit the web site.

****Delete CA Certificates

Are you sure you want to delete these CA certificates?

[list of subject names]

If you delete a certificate authority (CA) certificate, your browser will no 
longer trust any certificates issued by that CA.

Comment 1

[Sean Cotter]

Changed target to 2.0.

Note also that these dialogs are supposed to have help buttons (ssuming that 
context-sensitivity stuff gets checked in soon). The targets are:

?delete_my_certs
?delete_web_certs
?delete_ca_certs

Comment 2

[Stephane Saux]

Mass reassigning target to 2.1

Comment 3

[Stephane Saux]

Marking new.

Comment 4

[Stephane Saux]

p2

Comment 5

[Stephane Saux]

rangansen

Comment 6

[Stephane Saux]

removing nsenterprise keyword from PSM bugs with target milestone of future.

Comment 7

[John Unruh]

Mass assigning QA to ckritzer.

Comment 8

[Rangan Sen]

Here is a patch that fixes this problem. However, this too, includes the kind of
strange workaround mention in bug# 94384

Comment 9

[Rangan Sen]

Attachment: patch

Comment 10

[Javier Delgadillo]

A couple of comments:

1) You could consider passing a nsIPKIParamBlock instead of a
nsIDialogParamBlock.  This allows you to pass nsISupports objects as well
(meaning you can pass a reference to the cert instead of just the certdbkey and
then have to look it up again.)  This is just for consideration, take or leave
it, either way.

These should get fixed:
1)In the <window... definition, avoid using a hard-coded width.  Use something
like style="width: 8ex" instead.  This causing the width to be relative to the
font size.

2) Add the absolute path for these JavaScript files and add the string
'type="application/x-javascript" to them as well.
 
<script src="deletecert.js"/>
+  <script type="application/x-javascript"
src="chrome://global/content/strres.js" />
+  <script src="pippki.js" />
<script type="application/x-javascript" src="chrome://help/content/help.js" />

3) Don't add 'style= "width.."' strings to buttons.  (Bug 88328)

Fix the above 3, and you have r=javi.

Comment 11

[Rangan Sen]

Attachment: patch

Comment 12

[Rangan Sen]

Done ...

Comment 13

[Joe Hewitt (gone)]

sr=hewitt

Comment 14

[Rangan Sen]

Patch checked in.
I would also like to point out that the window, being persistent, remembers the
older value, and might show sizing issues first time, depending on the profile
used [bug# 94755]. This might be resized, though.

Comment 15

[ckritzer (gone)]

Marking VERIFIED FIXED on:
-MacOS91 2001-08-15-08-trunk (commercial)
-MacOS_X 2001-08-15-05-trunk (commercial)
-LinRH62 2001-08-15-08-trunk (commercial)
-Win98SE 2001-08-15-06-trunk (commercial)