pretty name default for servers is hardcoded

RESOLVED WORKSFORME

Status

SeaMonkey
MailNews: Message Display
P2
normal
RESOLVED WORKSFORME
17 years ago
9 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Unassigned)

Tracking

({l12y})

Trunk
mozilla1.2alpha
x86
Other
Dependency tree / graph
Bug Flags:
blocking-seamonkey1.1a -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments)

looking at 

http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgIncomingServer.cpp#616

we default the pretty name to be "<username> on <hostname".

" on " is hardcoded.  that string should live in a string bundle.
it's a little trickier than that.

something like "%S1 on %S2" should live in a bundle (where we tell the localizer
that S1 is username and S2 is hostname.

if no username, then we just have the hostname and we don't need a format string
for that.

Updated

17 years ago
Keywords: l12y

Updated

16 years ago
Keywords: nsBranch

Updated

16 years ago
Blocks: 99230

Comment 2

16 years ago
cleaning up nsbranch keywords. not an emojo stopper.
Keywords: nsbranch → nsbranch-

Updated

16 years ago
No longer blocks: 99230

Updated

16 years ago
Blocks: 107067

Updated

16 years ago
Keywords: nsbranch-

Comment 3

16 years ago
nominating for nsbeta1
Keywords: nsbeta1

Updated

16 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9

Updated

16 years ago
Keywords: nsbeta1 → nsbeta1+
Priority: -- → P2

Updated

16 years ago
Target Milestone: mozilla0.9.9 → mozilla1.0

Comment 4

16 years ago
Seth, is this visible to the user? does anyone know how to bring it up?  

Updated

16 years ago
Blocks: 122274
Keywords: nsbeta1+ → nsbeta1-
Target Milestone: mozilla1.0 → mozilla1.2
mass re-assign.
Assignee: racham → sspitzer
Status: ASSIGNED → NEW
Product: Browser → Seamonkey

Updated

13 years ago
Assignee: sspitzer → mail
Created attachment 196201 [details] [diff] [review]
the easy way out

Makes it like
<http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapIncomingServer.cpp#200>.
Attachment #196201 - Flags: review?(bienvenu)

Comment 7

12 years ago
I think I'd prefer the full localized solution instead of going back to a@b.
Scott, what do you think?
Are we certain "<user> on <host>" is the right order in every language? Either
way, any such languages can use "%S@%S" ...

Localized patch coming in a little while.

Comment 9

12 years ago
No, we're not - see comment #1
Created attachment 196238 [details] [diff] [review]
localized

Not quite sure about putting it in messenger.properties or the name
(accountPrettyName).
Attachment #196238 - Flags: review?(bienvenu)
Flags: blocking-seamonkey1.1a?

Comment 11

11 years ago
Beter L12y would really be nice to have, but we won't block a release for it, even no Alpha.

bienvenu, could you really review this? It affects localization of both Thunderbird and SeaMonkey...
Flags: blocking-seamonkey1.1a? → blocking-seamonkey1.1a-

Comment 12

11 years ago
I'm much more inclined to go for the second patch than the first patch. Unfortunately, the second patch doesn't apply cleanly against the trunk, so I need  to apply it by hand to test it out.

Comment 13

11 years ago
this patch didn't work for me - we always end up creating a pretty name of user@host - we might need to change the account wizard to try to get the "constructed" pretty name.

Comment 14

11 years ago
I only tried this in TB, actually - but I suspect it's the same for SM - we create accounts with the name user@host already. I'm not inclined to change that at this point. Please let me know if I'm mistaken...

Updated

10 years ago
Attachment #196201 - Flags: review?(bienvenu) → review-

Comment 15

9 years ago
David, does that make attachment 196238 [details] [diff] [review] review- for you?  Or is this blocked by account wizardry?
Assignee: mail → nobody
QA Contact: esther → message-display

Comment 16

9 years ago
Comment on attachment 196238 [details] [diff] [review]
localized

yes, minus. I think this bug is invalid/wfm now - we create accounts with pretty name username@host, not user on host.
Attachment #196238 - Flags: review?(bienvenu) → review-

Comment 17

9 years ago
wfm per comment 16
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.