looking at http://lxr.mozilla.org/seamonkey/source/mailnews/base/util/nsMsgIncomingServer.cpp#616 we default the pretty name to be "<username> on <hostname". " on " is hardcoded. that string should live in a string bundle.
it's a little trickier than that. something like "%S1 on %S2" should live in a bundle (where we tell the localizer that S1 is username and S2 is hostname. if no username, then we just have the hostname and we don't need a format string for that.
cleaning up nsbranch keywords. not an emojo stopper.
nominating for nsbeta1
Seth, is this visible to the user? does anyone know how to bring it up?
Created attachment 196201 [details] [diff] [review] the easy way out Makes it like <http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapIncomingServer.cpp#200>.
I think I'd prefer the full localized solution instead of going back to a@b. Scott, what do you think?
Are we certain "<user> on <host>" is the right order in every language? Either way, any such languages can use "%S@%S" ... Localized patch coming in a little while.
No, we're not - see comment #1
Created attachment 196238 [details] [diff] [review] localized Not quite sure about putting it in messenger.properties or the name (accountPrettyName).
Beter L12y would really be nice to have, but we won't block a release for it, even no Alpha. bienvenu, could you really review this? It affects localization of both Thunderbird and SeaMonkey...
I'm much more inclined to go for the second patch than the first patch. Unfortunately, the second patch doesn't apply cleanly against the trunk, so I need to apply it by hand to test it out.
this patch didn't work for me - we always end up creating a pretty name of user@host - we might need to change the account wizard to try to get the "constructed" pretty name.
I only tried this in TB, actually - but I suspect it's the same for SM - we create accounts with the name user@host already. I'm not inclined to change that at this point. Please let me know if I'm mistaken...
David, does that make attachment 196238 [details] [diff] [review] review- for you? Or is this blocked by account wizardry?
Comment on attachment 196238 [details] [diff] [review] localized yes, minus. I think this bug is invalid/wfm now - we create accounts with pretty name username@host, not user on host.
wfm per comment 16