Closed Bug 858016 Opened 7 years ago Closed 7 years ago

Double click does not enable fullscreen mode

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
mozilla23

People

(Reporter: cornel_ionce, Assigned: maxli)

Details

(Whiteboard: [mentor=jaws][lang=js])

Attachments

(1 file)

Steps to reproduce:
1. Launch firefox.
2. Drag and drop a video file (I've used a MP4) to your browser .
3. Double click on the stream zone.

Expected result:
The video enters fullscreen mode.

Actual result:
The video is paused/resumed.

Tested on Windows 7x64 and Windows 8x32 with:
Nightly (build ID: 20130404030859)
Aurora (build ID: 20130403004013)
Fixing this bug may be quite complicated, since AIUI if we add an event listener for the dblclick event, we will still receive two `click` events before the `dblclick` event.

If we respond to the first two click events, the video will either stutter (as the user goes from playing -> paused -> playing) or will move (paused -> playing -> paused).

If we decide that fixing this bug is worthwhile, the simple solution would be to accept the aforementioned jitter in playback. Otherwise we may need to add some kind of delay to the play/pause single-click handling (which I think would be detrimental and add unwanted jank).

/toolkit/content/widgets/videocontrols.xml is the file that will need to be modified to fix this bug.
Whiteboard: [mentor=jaws][lang=js]
Why would one expect doubleclick to invoke fullscreen mode?
I would expect this, it's quite common.

The following players have this behaviour:
* Windows Media Player
* VLC on Windows
* YouTube.com's player
* Vimeo.com's player
* Chrome's built-in HTML5 <video> controls
* Internet Explorer 10's built-in HTML5 <video> controls

QuickTime player on Windows doesn't toggle fullscreen on doubleclick FWIW, and it's the only player out of those that I checked which doesn't have this behaviour. Maybe it's not so common behaviour on Mac?
I've reproduced it on my Mac OS 10.7 and I've found another weird behavior. Whan I pause a video with one click, the video only replay if I peform a double click.

cpearce, I'm a Mac user and in all video players I perform a double click to fullscreen.

The steps for reproduce the bug is:

1. Drag a .mp4 or .m4v file in the firefox;
2. Click in the video to pause;
3. click once time to replay, but nothing happens.
4. Peform a double click, and the video replays, but It's not every time. Sometimes I need to peform more than one double click;
(In reply to Caio Lima(:caiolima) from comment #4)
> Whan I pause a video with one click, the video only replay if I peform a
> double click.

That's a different bug.

(In reply to Jared Wein [:jaws] from comment #1)
> If we respond to the first two click events, the video will either stutter
> (as the user goes from playing -> paused -> playing) or will move (paused ->
> playing -> paused).
> 
> If we decide that fixing this bug is worthwhile, the simple solution would
> be to accept the aforementioned jitter in playback.

This is what YouTube goes with, FWIW (the "jitter is acceptable" approach).  Given that that's probably what most people watching Web video are used to, we should shoot for parity there, yeah?  It also happens to be the easier approach, so, y'know... :)
Attached patch PatchSplinter Review
Patch follows the simple solution of accepting the jitter.
Assignee: nobody → maxli
Attachment #740147 - Flags: review?(jaws)
Comment on attachment 740147 [details] [diff] [review]
Patch

Review of attachment 740147 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks! Yeah, I see YouTube has the same experience.
Attachment #740147 - Flags: review?(jaws) → review+
Keywords: checkin-needed
OS: Windows 7 → All
https://hg.mozilla.org/mozilla-central/rev/7567cbe92349
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
QA Contact: cornel.ionce
Verified as fixed on Firefox 23 beta 2 (build ID: 20130701144430).

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0
User Agent: Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20100101 Firefox/23.0
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.