858033 - Reduce aws cron noisiness

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

Attachment: don't panic

It would be great to reduce aws cron noisiness so we can see important messages only.

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 733285 [details] [diff] [review]
don't panic

Review of attachment 733285 [details] [diff] [review]:
-----------------------------------------------------------------

::: aws/aws_watch_pending.py
@@ +234,5 @@
>          # Check for stopped instances in the given regions and start them if there are any
>          started = aws_resume_instances(instance_type, count, regions, secrets, region_priorities, dryrun)
>          count -= started
> +        if count:
> +            log.info("%s - started %i instances; need %i", instance_type, started, count)

sometimes it is useful for me to see qty of started instances, can we at least do a log.debug in the "no more to start" case, enumerating the qty of newly started instances in each region.

Comment 2

[Rail Aliiev [:rail]]

Attachment: don't panic v2

sure!

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 733525 [details] [diff] [review]
don't panic v2

Review of attachment 733525 [details] [diff] [review]:
-----------------------------------------------------------------

::: aws/aws_stop_idle.py
@@ +228,3 @@
>                          i.stop()
> +                    else:
> +                        log.info("%s - not stopping, graceful shutdown required" % name)

change to "not stopping, waiting for graceful shutdown" or something similar? we've already initiated the shutdown at this point.

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 733525 [details] [diff] [review]
don't panic v2

http://hg.mozilla.org/build/cloud-tools/rev/0a6be5c105bf