858183 - knox/S3 is not compatible with node v0.10

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jon Buckley]

JP and I discovered this while testing the migration procedure. You'll get the following error: "Error: Hostname/IP doesn't match certificate's altnames"

If you add an error handler to S3FileStore.prototype.write() then it's possible to catch it:

diff --git a/lib/file-store.js b/lib/file-store.js
index eca089b..43e1455 100644
--- a/lib/file-store.js
+++ b/lib/file-store.js
@@ -151,6 +151,9 @@ S3FileStore.prototype.write = function( key, data, callback ) {
       callback( res.statusCode );
     }
   })
+  .on( 'error', function( blah ) {
+    console.log( arguments );
+  })
   .end( data );
 };

Comment 1

[David Humphrey (:humph)]

I see that knox 0.6.0 is out, which adds support for 0.10, see:

https://github.com/LearnBoost/knox/blob/master/History.md#060--2013-03-24

Comment 2

[Jon Buckley]

We should also consider using the official SDK: https://github.com/aws/aws-sdk-js

Comment 3

[Jon Buckley]

Attachment: https://github.com/mozilla/butter/pull/1665

I played with the aws-sdk on the weekend, and it's a pain. So lets just update to v0.7.0!

Comment 4

[David Humphrey (:humph)]

Comment on attachment 737477 [details] [review]
https://github.com/mozilla/butter/pull/1665

This looks sane to me.  I'd like to see it run on staging, assuming we do AWS publishing there?  It's a bit hard to test it locally end-to-end.

r+ on the code change.

JP, can you deploy this somehow and see that publishing doesn't break for new stuff?

Comment 5

[JP Schneider :jp]

So which version node should we test on?  v0.10?  I can setup staging to have whichever version and push a tagged version up, if you tag it.

Comment 6

[David Humphrey (:humph)]

Yeah, v0.10. jbuck, can you tag so he can test deploy?

Comment 7

[Jon Buckley]

Merged into master: https://github.com/mozilla/butter/commit/251093c518c06ed1cc7c04ed324b1c055287fa88