858196 - Move all customization code to be under browser/components/customizableui/

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

At some point, we should start writing some regression tests for the customization code - but I'm not entirely sure where that sort of thing should go.

1) Create browser/components/customization
2) Move CustomizableUI.jsm and CustomizeMode.jsm into browser/components/customization/src
3) Customization content (non-style CSS, for example) could go into browser/components/customization/content
4) Tests go into browser/components/customization/tests

Stop me if I'm suggesting busy-work, but I figure if this sounds like a good idea, we might as well do it earlier rather than later.

Thoughts?

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Seems reasonable - bit nicer for new people to find it and start hacking on it too.

But I vaguely remember Gavin saying he'd like less directories, not more - but I could be wrong. Gavin?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Sounds fine!

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

I figure we're better to do this now and pay a small up-front cost, than hold off to do it later and pay a bigger cost.

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch v1

Warning: This makes extensive use of file renames, which Bugzilla's review tool doesn't show at all :\ Manual inspection of the diff file is recommended.

"customization" seems ambiguous to me, and doesn't cover all the code that isn't directly handling the act of customizing. So I've gone with browser/components/customizableui/

I've also cleaned up some file names, standardizing on conventions such as aboutCustomizing.xhtml (used by other about pages), customizing.inc -> customizeMode.inc.xul (fixing the extension, and gaining consistency with CustomizeMode.jsm) etc.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 737403 [details] [diff] [review]
Patch v1

LGTM. Thanks!

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Landed in jamun as https://hg.mozilla.org/projects/jamun/rev/7670bd970290

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Follow-up to fix OSX builds

The jar.mn for OSX was pointing to the wrong directory for customization-mode-background.jpg. This patch fixes that.

I r=trivial'd it. Hope that wasn't too Maverick of me. :)

Landed on Jamun as https://hg.mozilla.org/projects/jamun/rev/15bdc4114dcc

Comment 8

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/projects/ux/rev/27517d483367

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Follow-up landed on UX as https://hg.mozilla.org/projects/ux/rev/15bdc4114dcc

Comment 10

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/27517d483367
https://hg.mozilla.org/mozilla-central/rev/15bdc4114dcc