Move all customization code to be under browser/components/customizableui/

RESOLVED FIXED in Firefox 28

Status

()

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mconley, Assigned: Unfocused)

Tracking

Trunk
Firefox 28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
At some point, we should start writing some regression tests for the customization code - but I'm not entirely sure where that sort of thing should go.

1) Create browser/components/customization
2) Move CustomizableUI.jsm and CustomizeMode.jsm into browser/components/customization/src
3) Customization content (non-style CSS, for example) could go into browser/components/customization/content
4) Tests go into browser/components/customization/tests

Stop me if I'm suggesting busy-work, but I figure if this sounds like a good idea, we might as well do it earlier rather than later.

Thoughts?
Seems reasonable - bit nicer for new people to find it and start hacking on it too.

But I vaguely remember Gavin saying he'd like less directories, not more - but I could be wrong. Gavin?
Flags: needinfo?(gavin.sharp)
Sounds fine!
Flags: needinfo?(gavin.sharp)
I figure we're better to do this now and pay a small up-front cost, than hold off to do it later and pay a bigger cost.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Summary: Consider moving customization code under browser/components/customization → Move all customization code to be under browser/components/customization
Created attachment 737403 [details] [diff] [review]
Patch v1

Warning: This makes extensive use of file renames, which Bugzilla's review tool doesn't show at all :\ Manual inspection of the diff file is recommended.

"customization" seems ambiguous to me, and doesn't cover all the code that isn't directly handling the act of customizing. So I've gone with browser/components/customizableui/

I've also cleaned up some file names, standardizing on conventions such as aboutCustomizing.xhtml (used by other about pages), customizing.inc -> customizeMode.inc.xul (fixing the extension, and gaining consistency with CustomizeMode.jsm) etc.
Attachment #737403 - Flags: review?(jaws)
Summary: Move all customization code to be under browser/components/customization → Move all customization code to be under browser/components/customizableui/
(Reporter)

Comment 6

6 years ago
Landed in jamun as https://hg.mozilla.org/projects/jamun/rev/7670bd970290
Whiteboard: [fixed in jamun]
(Reporter)

Comment 7

6 years ago
Created attachment 740275 [details] [diff] [review]
Follow-up to fix OSX builds

The jar.mn for OSX was pointing to the wrong directory for customization-mode-background.jpg. This patch fixes that.

I r=trivial'd it. Hope that wasn't too Maverick of me. :)

Landed on Jamun as https://hg.mozilla.org/projects/jamun/rev/15bdc4114dcc
Attachment #740275 - Flags: review+
(Reporter)

Comment 8

6 years ago
https://hg.mozilla.org/projects/ux/rev/27517d483367
Whiteboard: [fixed in jamun] → [fixed in jamun][fixed-in-ux]

Comment 10

5 years ago
https://hg.mozilla.org/mozilla-central/rev/27517d483367
https://hg.mozilla.org/mozilla-central/rev/15bdc4114dcc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in jamun][fixed-in-ux]
Target Milestone: --- → Firefox 28

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.