Closed Bug 858211 Opened 7 years ago Closed 7 years ago

Use more webidl features for HTMLAudioElement

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(1 file)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #733507 - Flags: review?(bzbarsky)
Comment on attachment 733507 [details] [diff] [review]
Patch v1

r=me
Attachment #733507 - Flags: review?(bzbarsky) → review+
Comment on attachment 733507 [details] [diff] [review]
Patch v1

>+++ b/content/html/content/public/HTMLAudioElement.h
>+  uint32_t MozWriteAudio(const Float32Array& aData, ErrorResult& aRv);
>+  uint32_t MozWriteAudio(const Sequence<float>& aData, ErrorResult& aRv);

Why not inline those two?
(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 733507 [details] [diff] [review]
> Patch v1
> 
> >+++ b/content/html/content/public/HTMLAudioElement.h
> >+  uint32_t MozWriteAudio(const Float32Array& aData, ErrorResult& aRv);
> >+  uint32_t MozWriteAudio(const Sequence<float>& aData, ErrorResult& aRv);
> 
> Why not inline those two?

No particular reason, I'd just been working in the cpp.
https://hg.mozilla.org/mozilla-central/rev/e22145c3b33e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Hi :Ms2ger,

This patch seems to cuase a regression on b2g project. The keytone from dialer app can't work anymore. (gaia/app/communication/dialer/js/keypad.js)

  1. I tired the changset 7ebd1eece7f0 and it is work but e22145c3b33e.
  2. The JS code is stopped at calling mozWriteAudioData().

Could you help on this regression? Thanks.
Marco, is there a exception thrown?  If so, which one?  Is there a bug tracking the problem?
And where does this code live?
> Marco, is there a exception thrown?  If so, which one?  Is there a bug tracking the problem?
I didn't see any warning or error message from adb logcat or console. And I didn't fire a bug yet but will and update here.

> And where does this code live?
The regression is not happened on b2g18 because it didn't be uplifted yet.
It happened when I want to commit a patch related to HTMLAudioElement and test it on m-c tree.
Fire a new bug for this. 
Bug 862409 - [Audio] Audio_Data API is broken When dialer app tried to send a keytone
You need to log in before you can comment on or make changes to this bug.