858211 - Use more webidl features for HTMLAudioElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 733507 [details] [diff] [review]
Patch v1

r=me

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 733507 [details] [diff] [review]
Patch v1

>+++ b/content/html/content/public/HTMLAudioElement.h
>+  uint32_t MozWriteAudio(const Float32Array& aData, ErrorResult& aRv);
>+  uint32_t MozWriteAudio(const Sequence<float>& aData, ErrorResult& aRv);

Why not inline those two?

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Boris Zbarsky (:bz) from comment #2)
> Comment on attachment 733507 [details] [diff] [review]
> Patch v1
> 
> >+++ b/content/html/content/public/HTMLAudioElement.h
> >+  uint32_t MozWriteAudio(const Float32Array& aData, ErrorResult& aRv);
> >+  uint32_t MozWriteAudio(const Sequence<float>& aData, ErrorResult& aRv);
> 
> Why not inline those two?

No particular reason, I'd just been working in the cpp.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/e22145c3b33e

Comment 5

[Marco Chen [:mchen]]

Hi :Ms2ger,

This patch seems to cuase a regression on b2g project. The keytone from dialer app can't work anymore. (gaia/app/communication/dialer/js/keypad.js)

  1. I tired the changset 7ebd1eece7f0 and it is work but e22145c3b33e.
  2. The JS code is stopped at calling mozWriteAudioData().

Could you help on this regression? Thanks.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Marco, is there a exception thrown?  If so, which one?  Is there a bug tracking the problem?

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And where does this code live?

Comment 8

[Marco Chen [:mchen]]

> Marco, is there a exception thrown?  If so, which one?  Is there a bug tracking the problem?
I didn't see any warning or error message from adb logcat or console. And I didn't fire a bug yet but will and update here.

> And where does this code live?
The regression is not happened on b2g18 because it didn't be uplifted yet.
It happened when I want to commit a patch related to HTMLAudioElement and test it on m-c tree.

Comment 9

[Marco Chen [:mchen]]

Fire a new bug for this. 
Bug 862409 - [Audio] Audio_Data API is broken When dialer app tried to send a keytone

Comment 10

[Boris Zbarsky [:bzbarsky]]

> And where does this code live?

http://mxr.mozilla.org/gaia/source/apps/communications/dialer/js/keypad.js fwiw.