Closed Bug 858212 Opened 7 years ago Closed 7 years ago

Move FileReader to Paris bindings

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → Ms2ger
Attached patch Patch v1Splinter Review
Attachment #734255 - Flags: review?(bzbarsky)
Comment on attachment 734255 [details] [diff] [review]
Patch v1

>+    aRv = NS_NewChannel(getter_AddRefs(mChannel), uri, nullptr, loadGroup,
>                        nullptr, nsIRequest::LOAD_BACKGROUND);

Please fix the indent.

>+  [Throw]
>+  void readAsBinaryString(Blob filedata);

s/Throw/Throws/, right?

r=me with those nits.  Sorry for the delay...
Attachment #734255 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/c3941d5b21f1
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.