858219 - Panel should switch to main view after closing

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We currently stay on a subview if the panel hides by changing focus. If the panel closes, we should always go back to the main view.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 733527 [details] [diff] [review]
Patch v1

Review of attachment 733527 [details] [diff] [review]:
-----------------------------------------------------------------

I guess the transition is short enough that we don't need to worry about it being noticeable when quickly closing/re-opening the panel, especially as the panel doesn't open and become visible instantaneously (I tried, and shouldn't see it... but this was over a remote desktop connection).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

There are two rules in panelUIOverlay.inc.css that (I believe) short-circuit the transitions when the panel is closed:

#PanelUI-popup[panelopen="true"] > #PanelUI-container {                         
  transition: height 150ms;                                                     
}                                                                               
                                                                                
#PanelUI-popup[panelopen="true"] > #PanelUI-container > #PanelUI-viewStack > #PanelUI-mainView {
  transition: transform 150ms;                                                  
}                                                                               

Assuming these rules are working as I think they are, the animations will only occur when the panel is open.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Landed in jamun as https://hg.mozilla.org/projects/jamun/rev/5ed3cad80eb5

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Landed in UX as https://hg.mozilla.org/projects/ux/rev/5ed3cad80eb5

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/0c24dab393f8