This was implemented just to workaround the fact that context-menu implementation was tightly coupled with previous event dispatch scheme. Since context-menu rewrite this is no longer a case, so we should remove emit.lazy in favor of more simpler implementation.
Comment on attachment 828807 [details] GH PR 1282 We need tests for `deferWithCallback`. Irakli does this api change look alright to you?
Comment on attachment 828807 [details] GH PR 1282 r+ with forEach changed to while and unrelated file removed. Erik, Yes kill emit.lazy with fire!!! It's actually was me who asked Jordan to do this :P I also assume that all test pass with this changes.
Accidentally had an extra promise util in there by accident -- disregard.
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/dcbb5ff8da3a6beb6282f3ded611ce427b6afd80 Bug 858222 Remove emit.lazy in event/core https://github.com/mozilla/addon-sdk/commit/82a7a9a38c59c7bc293a27305d0bda566cd457f7 Merge pull request #1282 from jsantell/858222-remove-emit-lazy Fix Bug 858222 Remove emit.lazy, r=@gozala
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.