Closed
Bug 858304
Opened 9 years ago
Closed 9 years ago
QuartzSupport.mm:943:20: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
1.07 KB,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
filing this bug for these two warnings in QuartzSupport.mm: { ../../../gfx/2d/QuartzSupport.mm:943:20: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] if (aX < 0 || aX >= ioWidth || ~~ ^ ~~~~~~~ ../../../gfx/2d/QuartzSupport.mm:944:20: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare] aY < 0 || aY >= ioHeight) { ~~ ^ ~~~~~~~~ } We can just static_cast aX and aY for the purpose of the comparison with ioWidth & ioHeight, since we'll never hit that comparison with negative aX or aY. (due to the < 0 checks)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dholbert
Blocks: buildwarning, 839269
Assignee | ||
Comment 1•9 years ago
|
||
Recent m-c log showing these warnings: https://tbpl.mozilla.org/php/getParsedLog.php?id=21414902&tree=Mozilla-Central
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #733601 -
Flags: review?
Assignee | ||
Updated•9 years ago
|
Attachment #733601 -
Flags: review? → review?(smichaud)
Comment 3•9 years ago
|
||
Comment on attachment 733601 [details] [diff] [review] trivial fix Looks fine to me.
Attachment #733601 -
Flags: review?(smichaud) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks for the quick turnaround! Try run (just mac builds), to be sure I didn't make a typo, since I'm not on a mac & can't test at the moment: https://tbpl.mozilla.org/?tree=Try&rev=3a7169f09bcd (c2f49a0c6110 is this bug's patch, in the pushed-to-try commits)
Assignee | ||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2edc2af0ec32
Flags: in-testsuite-
OS: Linux → Mac OS X
Hardware: x86_64 → All
Comment 6•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2edc2af0ec32
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in
before you can comment on or make changes to this bug.
Description
•