858304 - QuartzSupport.mm:943:20: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daniel Holbert [:dholbert]]

filing this bug for these two warnings in QuartzSupport.mm:
{
../../../gfx/2d/QuartzSupport.mm:943:20: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
  if (aX < 0 || aX >= ioWidth ||
                ~~ ^  ~~~~~~~
../../../gfx/2d/QuartzSupport.mm:944:20: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
      aY < 0 || aY >= ioHeight) {
                ~~ ^  ~~~~~~~~
}

We can just static_cast aX and aY for the purpose of the comparison with ioWidth & ioHeight, since we'll never hit that comparison with negative aX or aY. (due to the < 0 checks)

Comment 1

[Daniel Holbert [:dholbert]]

Recent m-c log showing these warnings:
 https://tbpl.mozilla.org/php/getParsedLog.php?id=21414902&tree=Mozilla-Central

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 733601 [details] [diff] [review]
trivial fix

Looks fine to me.

Comment 4

[Daniel Holbert [:dholbert]]

Thanks for the quick turnaround!

Try run (just mac builds), to be sure I didn't make a typo, since I'm not on a mac & can't test at the moment:
 https://tbpl.mozilla.org/?tree=Try&rev=3a7169f09bcd
(c2f49a0c6110 is this bug's patch, in the pushed-to-try commits)

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2edc2af0ec32

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2edc2af0ec32