858330 - PhoneNumberJS: Fix chilean mobile numbers

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

Merge from upstream: 
https://github.com/andreasgal/PhoneNumber.js/pull/17

This PR is a fix on a parsing bug that happens for Chilean mobile numbers.

The chilean metadata array has a value for nationalPrefixForParsing, but nationalPrefixTransformRule is empty.

When parsing the metadata array, md.nationalPrefixTransformRule is not created (undefined) and then the replace function at line 438 inserts "undefined" at the beginning of the chilean mobile numbers.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

We can't parse chilean phone numbers.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 733638 [details] [diff] [review]
patch

Review of attachment 733638 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing, r=me.

Comment 4

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1576f07a1d8b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1576f07a1d8b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/3f96276c678a
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/5abca3564123