858339 - PhoneNumberJS: Fix colombian phone numbers without the leading +

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

https://github.com/andreasgal/PhoneNumber.js/pull/18



Colombian mobile numbers can be called without the leading "+". Google's libphonenumber supports it but PhoneNumber.js doesn't.

The problem is that PhoneNumber.js first checks that the number is a possible national number and if it isn't then it checks if it can be an international number without the leading "+".

The check of possible national numbers more loose than the check of being an international number, so most international numbers without the leading "+" are considered national numbers.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

We should take it if Columbia is one of the initial target markets.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 733653 [details] [diff] [review]
patch

Review of attachment 733653 [details] [diff] [review]:
-----------------------------------------------------------------

Stealing, r=me.

Comment 4

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db1838b65293

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db1838b65293

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2ff11a06ea81
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/2f644c14f333