858449 - [SMS] The Contact search list from SMS app is not clearing when we touch backspace quickly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P3)

Description

[sasikala]

1. Title : Contact search list from SMS app is not clearing when we touch backspace quickly
2. Precondition : Some contacts should be available in contacts app.
3. Tester's Action : Messages - New Message - input field - Enter the name of the contact which is present in contacts app - touch backspace quickly
4. Detailed Symptom (ENG.): The search list is not deleting when we touch the backspace quickly.
5. Expected : The search list should not be visible when we touch the backspace quickly.
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Revision: 8e7262e3d98ea9574d7f79c1e890ad80cfa40c27

Comment 1

[sasikala]

Attachment: Pointer to pull request

Comment 2

[sasikala]

Attachment: Pointer to pull request

Comment 3

[Borja Salguero [:borjasalguero]]

Could you specify the steps to reproduce it? Thanks!

Comment 4

[Leo]

Attachment: Pointer to pull request

Comment 5

[Leo]

Attachment: Pointer to pull request

Comment 6

[sasikala]

Hi Borja,

The steps for reproducing this issue is
Save some contacts in Contacs app starting with same name
1.Go to SMS app
2.Select New Message icon
3.Click on input field
4.Enter the name of the contact which is present in contacts app
5.Touch backspace quickly

The contact list is not clearing when we click on backspace fastly

Thanks,

Comment 7

[sasikala]

Hi Borja,

Please review the patch and provide your comments.

Thanks

Comment 8

[Rick Waldron [:rwaldron]]

Why is this patch already marked "r=borjasalguero"?

Comment 9

[Borja Salguero [:borjasalguero]]

@sasikala: I agree Rick comments. Please update your PR and squash your changes.

@Rick: Due to for getting a review, we should add at least one of the 'peers'. In this case Julien and I (you can check the info of all apps 'peers' here https://wiki.mozilla.org/Modules/FirefoxOS)

Comment 10

[Leo]

Attachment: Pointer to Pull Request https://github.com/mozilla-b2g/gaia/pull/9089

Comment 11

[Borja Salguero [:borjasalguero]]

Testing again. Thanks!

Comment 12

[sasikala]

Tested and uploaded patch with comments and new pull request.
Please review and provide your comments.

Thanks,

Comment 13

[Rick Waldron [:rwaldron]]

Needs to be rebased, then r=me

Comment 14

[Leo]

Hi Rick,

I will rebase and upload the patch again.

Thanks,
Leo

Comment 15

[Leo]

Hi Rick,

Rebase is done.Please review and provide your comments.

Thanks,
Leo

Comment 16

[Borja Salguero [:borjasalguero]]

Leo, please take a look to the comment https://github.com/mozilla-b2g/gaia/pull/9089/files#r3975326 . I don't know even if this is a bug with the current code in master.

Comment 17

[Borja Salguero [:borjasalguero]]

Comment on attachment 735754 [details]
Pointer to Pull Request https://github.com/mozilla-b2g/gaia/pull/9089

Please take a look to the comment in the PR. THanks!

Comment 18

[Leo]

Hi Borja,

I have tested this in master code.This defect is still existing even in master code.

Thanks

Comment 19

[Leo]

Attachment: Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9474

Hi,

Tested and Uploaded the patch with the changes as per the master code.
Please review and provide your comments.

Thanks,
Leo

Comment 20

[Borja Salguero [:borjasalguero]]

Please update the commit name with the right bug number and for me it's r+.

Comment 21

[Borja Salguero [:borjasalguero]]

Comment on attachment 743461 [details]
Pointer to pull request https://github.com/mozilla-b2g/gaia/pull/9474

Update the commit name and we are done!

Comment 22

[Borja Salguero [:borjasalguero]]

Merged.
https://github.com/leob2g/gaia/commit/bd63d95c2d86e9255637a1f8fd9629fa48de56f5
https://github.com/mozilla-b2g/gaia/commit/46153e2871265083bceae41f1c6bb95a116758f0

Comment 23

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 46153e2871265083bceae41f1c6bb95a116758f0 to:
v1-train: c3e2c1c8ddb9b4883a7f102276a17ba6692b2b0b