858455 - Failure to link jsapi-tests with --enable-system-ffi

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add system ffi flags when building jsapi-tests and gdb-tests

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 733814 [details] [diff] [review]
Add system ffi flags when building jsapi-tests and gdb-tests

Review of attachment 733814 [details] [diff] [review]:
-----------------------------------------------------------------

There's not much context to go on in the bug report. My only concern was whether blindly adding MOZ_FFI_LIBS was a bad idea. But, from my local builds, it appears MOZ_FFI_LIBS is empty if we're not using --enable-system-ffi, so it doesn't seem like a big deal.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88d8ab81db89

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88d8ab81db89

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 733814 [details] [diff] [review]
Add system ffi flags when building jsapi-tests and gdb-tests

[Approval Request Comment]
User impact if declined: build with --enable-system-libffi fails
Testing completed (on m-c, etc.): Tested on Debian builds
Risk to taking this patch (and alternatives if risky): NPOTB
String or IDL/UUID changes made by this patch: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/53d302da1492