858466 - /firefox/new/ dividers in footer links are misaligned.

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[Mike de Boer [:mikedeboer]]

Attachment: screenshot of misaligned divider(s)

When you look at the footer of http://www.mozilla.org/en-US/firefox/new/ you'll notice that first and second row of links are oddly aligned when you look at the dividers.

Comment 1

[Chris More [:cmore]]

Do you mean the dividers are shifted to the right instead of being centered between the links?

Comment 2

[Mike de Boer [:mikedeboer]]

(In reply to Chris More [:cmore] from comment #1)
> Do you mean the dividers are shifted to the right instead of being centered
> between the links?

the divider on the second row of links inside the pages' footer is indeed not centered between the two links.

I see two possible solutions:
1. remove the divider that sits between 'Privacy Policy' and 'Legal Notices' altogether - because it's not really needed anyway, or
2. align the divider that sits between 'Privacy Policy' and 'Legal Notices' with the divider that sites between 'MOBILE' and 'ADD-ONS' and make sure the margins on both sides of the divider are equal. In that case it would indeed appear more centered than it is now.

I hope I explained it properly :S Would you like me to create to images that illustrate the two possible solutions I mentioned above?

Comment 3

[Mike de Boer [:mikedeboer]]

*two images

Comment 4

[Chris More [:cmore]]

The original implementation bug shows no dividers between the footer links:

https://bugzilla.mozilla.org/show_bug.cgi?id=814203#c20

Lee/John: Do you know if the dividers on the final HTML version were an oversight? The visual designs do not appear to have any.

Comment 5

[Lee Tom]

There were no divider lines in my mockups for this page, only the blue carats after the page links "»". 

Can we leave the divider lines out of the first line of links, "Tour» Desktop» etc"
but evenly space one divider line between Privacy Policy and Legal Notices?

Comment 6

[Jennifer Bertsch [:jbertsch]]

adding to kanban board

Comment 7

[Alex Gibson [:agibson]]

PR submitted: https://github.com/mozilla/bedrock/pull/796

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/56fe626430ea2569c63fe713dba1b90fde8168c5
Fix bug 858466 - firefox new, dividers in footer links are misaligned.

https://github.com/mozilla/bedrock/commit/6c3713cf4a7316b814f6dc32414d786120099c94
Merge pull request #796 from alexgibson/bug-858466-firefox-new-dividers-footer-misaligned

Fix bug 858466 - firefox new, dividers in footer links are misaligned.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://www.allizom.org/en-US/firefox/new/

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 11

[Mike de Boer [:mikedeboer]]

Yay! Thanks, this made my eyes very happy :)

Comment 12

[Paul [:pmac] McLanahan]

Verified in prod.