nsCycleCollector.h : Extra comma in enum declaration produce many warnings (-pedantic) in TB TryServer build

RESOLVED FIXED in mozilla23

Status

()

Core
XPCOM
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: ISHIKAWA, Chiaki, Assigned: ISHIKAWA, Chiaki)

Tracking

Trunk
mozilla23
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 733790 [details] [diff] [review]
Patch to eliminate the extra comma

Extra comma in enum declaration produce many warnings (-pedantic) in TB TryServer build.

Patch attached.
(Assignee)

Updated

5 years ago
Attachment #733790 - Flags: review?(khuey)
(Assignee)

Comment 1

5 years ago
Created attachment 733818 [details] [diff] [review]
Patch to eliminate the extra comma (in proper git format)

Here is a patch in proper git format.
TIA
Assignee: nobody → ishikawa
Attachment #733790 - Attachment is obsolete: true
Attachment #733790 - Flags: review?(khuey)
Attachment #733818 - Flags: review?(khuey)
Attachment #733818 - Flags: review?(khuey) → review+
Thanks for the patch!  I can land it for you if Ryan doesn't get to it first.
Keywords: checkin-needed
(Assignee)

Comment 3

5 years ago
Thank you!
Blocks: 839025
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e640b1edc504
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.