858590 - Remove auto positioning code from MenuUI

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect)

Description

[Jim Mathies [:jimm]]

We force position everything now, this code is no longer in use.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 733879 [details] [diff] [review]
patch

Review of attachment 733879 [details] [diff] [review]:
-----------------------------------------------------------------

Yay for less code. Looks good and works well (after updating/merging).

::: browser/metro/base/content/helperui/MenuUI.js
@@ -36,5 @@
>    },
>  
>    _positionOptions: function _positionOptions() {
>      let options = {};
> -    options.forcePosition = true;

This bitrotted a little - _positionOptions now returns { ... }.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c8f2ba905b1