858639 - Mochitest-browser-chrome fails since 20/03/2013

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Frank Wein [:mcsmurf]]

The mochitest-browser-chrome test crashes since 20/03/2013 on the SeaMonkey testboxen, see http://tbpl.drapostles.org/?tree=SeaMonkey&rev=8a50d60dd7a0, for reference:
"mochitest-browser-chrome exception
=== Output ===
'python' 'mochitest/runtests.py' '--appname=seamonkey/seamonkey.exe' '--utility-path=bin' '--extra-profile-file=bin/plugins' '--certificate-path=certs' '--autorun' '--close-when-done' '--console-level=INFO' '--symbols-path=symbols' '--browser-chrome'
[...]
TEST-UNEXPECTED-FAIL | automation.py | application timed out after 330 seconds with no output

Regression range:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4caaa0bc587d&tochange=a73a2b5c423b

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Screenshot from Windows test box after timeout

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Build log from mochitest-browser-chrome test (Windows)

Comment 3

[Frank Wein [:mcsmurf]]

Ok, this is because of Bug 851516.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Do you know why? That patch shouldn't have impacted SeaMonkey.

Comment 5

[Frank Wein [:mcsmurf]]

I guess we just need to port the patch from Bug 851516 :). SeaMonkey browser chrome tests use browser-test.js to run the test suite.

Comment 6

[Frank Wein [:mcsmurf]]

Oh, now that I look at the patch I see what you mean. Hm, not sure why it doesn't work anymore..

Comment 7

[Frank Wein [:mcsmurf]]

One last comment on this for now, this JS error looks related:
JavaScript error: chrome://mochikit/content/browser-test.js, line 112: NS_ERROR_FAILURE: Failure

Maybe the mentioned bug # is not related?!

Comment 8

[Frank Wein [:mcsmurf]]

Removing dependency, likely caused by another bug.

Comment 9

[Frank Wein [:mcsmurf]]

This assertion appears when it tries to access Object.keys(window) in line 112, browser-test.js (window is [ChromeWindow]):
###!!! ASSERTION: This is not supposed to fail!: 'Error', file e:/builds/slave/c-cen-t-w32-dbg/build/mozilla/js/xpconnect/src/nsXPConnect.cpp, line 924
nsXPConnect::GetWrappedNativePrototype(JSContext *,JSObject *,nsIClassInfo *,nsIXPConnectJSObjectHolder * *) [js/xpconnect/src/nsXPConnect.cpp:1703]
GetXPCProto [dom/base/nsDOMClassInfo.cpp:4291]
nsWindowSH::GlobalResolve(nsGlobalWindow *,JSContext *,JSObject *,jsid,bool *) [dom/base/nsDOMClassInfo.cpp:4639]
nsWindowSH::NewResolve(nsIXPConnectWrappedNative *,JSContext *,JSObject *,jsid,unsigned int,JSObject * *,bool *) [dom/base/nsDOMClassInfo.cpp:5140]
XPC_WN_Helper_NewResolve [js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1038]
js::baseops::LookupProperty<1>(JSContext *,JS::Handle<JSObject *>,JS::Handle<jsid>,JS::MutableHandle<JSObject *>,JS::MutableHandle<js::Shape *>) [js/src/jsobj.cpp:3518]
LookupPropertyById [js/src/jsapi.cpp:3568]
JS_LookupPropertyById(JSContext *,JSObject *,jsid,JS::Value *) [js/src/jsapi.cpp:3618]
JS_LookupUCProperty(JSContext *,JSObject *,wchar_t const *,unsigned int,JS::Value *) [js/src/jsapi.cpp:3645]
ResolveGlobalName [dom/base/nsDOMClassInfo.cpp:3447]
EnumerateGlobalName [dom/base/nsScriptNameSpaceManager.cpp:837]
PL_DHashTableEnumerate [objdir/mozilla/xpcom/build/pldhash.cpp:714]
nsScriptNameSpaceManager::EnumerateGlobalNames(PLDHashOperator (*)(nsAString_internal const &,void *),void *) [dom/base/nsScriptNameSpaceManager.cpp:845]
nsWindowSH::Enumerate(nsIXPConnectWrappedNative *,JSContext *,JSObject *,bool *) [dom/base/nsDOMClassInfo.cpp:3476]
XPC_WN_JSOp_Enumerate(JSContext *,JS::Handle<JSObject *>,JSIterateOp,JS::MutableHandle<JS::Value>,JS::MutableHandle<jsid>) [js/xpconnect/src/XPCWrappedNativeJSOps.cpp:1193]
Snapshot [js/src/jsiter.cpp:232]

Maybe Bug 851887 is related?

Comment 10

[Frank Wein [:mcsmurf]]

Attachment: Patch

Ian: It turned out Bug 604039 added a new .xpt file. We need to also add this. The missing .xpt file caused the assertion and failing browser chrome test. Since Bug 846540 we don't need to port configure.in AC_SUBST/AC_DEFINE changes from mozilla-central anymore.

Comment 11

[Frank Wein [:mcsmurf]]

Comment on attachment 738085 [details] [diff] [review]
Patch

Merging this bug with Bug 862701

Comment 12

[Frank Wein [:mcsmurf]]

Should all be fixed now by Bug 863672 and Bug 862701

Comment 13

[Frank Wein [:mcsmurf]]

Looks like comm-aurora browser chrome mochitest is still broken, need to update package-manifest.in again.

Comment 14

[Serge Gautherie (:sgautherie)]

Is this bug (fully) "fixed" now?

Comment 15

[Frank Wein [:mcsmurf]]

I can't really tell as mochitests are broken on comm-aurora.

Comment 16

[Frank Wein [:mcsmurf]]

But then on comm-beta mochitest-browser-chrome seems to run (with a few errors). I guess I can call this fixed for now.