Cannot activate Facebook Messenger via activation page

VERIFIED FIXED in Firefox 23

Status

defect
VERIFIED FIXED
6 years ago
4 months ago

People

(Reporter: ashughes, Assigned: mixedpuppy)

Tracking

({regression})

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

When I go to Facebook's activation page and try to activate their social provider I get the following error in error console:

> NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getComplexValue]
> resource://gre/modules/SocialService.jsm#497

This is a regression in Firefox Nightly 23.0a1 starting 2013-04-05 so I suspect bug 851936 has caused it.
Reporter

Updated

6 years ago
Blocks: 851936
No longer blocks: 851963
Assignee

Comment 1

6 years ago
Posted patch fix call to getDefaultBranch (obsolete) — Splinter Review
old-style activation that facebook uses got broken, and the test didn't cover that situation.  test added.
Assignee: nobody → mixedpuppy
Attachment #734070 - Flags: review?(gavin.sharp)
Comment on attachment 734070 [details] [diff] [review]
fix call to getDefaultBranch

Per IRC discussion, need to move the test to browser_social_activation.
Attachment #734070 - Flags: review?(gavin.sharp)
Assignee

Comment 3

6 years ago
Posted patch fix call to getDefaultBranch (obsolete) — Splinter Review
Attachment #734070 - Attachment is obsolete: true
Attachment #734106 - Flags: review?(gavin.sharp)
Assignee

Comment 4

6 years ago
this just fixes test result text I erroneously changed.
Attachment #734106 - Attachment is obsolete: true
Attachment #734106 - Flags: review?(gavin.sharp)
Attachment #734116 - Flags: review?(gavin.sharp)
Attachment #734116 - Flags: review?(gavin.sharp) → review+
Assignee

Comment 5

6 years ago
running a quick validation of new tests

https://tbpl.mozilla.org/?tree=Try&rev=09f96beab6d0
https://hg.mozilla.org/mozilla-central/rev/c713727a3cf6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
(In reply to Phil Ringnalda (:philor) from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/c713727a3cf6

Verified fixed in Firefox Nightly 23.0a1 2013-04-08.
Status: RESOLVED → VERIFIED

Updated

4 months ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.