85867 - langenus.xpi does not install properly when smartupdating

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

When smartupdating from 6.0x -> 6.1b1, langenus.xpi will not correctly detect 
which OS it is running from.  This is because during this smartupdate scenario, 
the browser is version 6.0.  This version of the browser does not support 
'Install.platform', only 6.1b1 does.  This will cause the wrong file to be 
registered.

This is filed in bugzilla because langenus.xpi from mozilla also has the same 
problem, not necessarily with N6.0x, but with earlier versions of mozilla.

patches for both mozilla and ns on all platforms coming up.

Comment 1

[Sean Su]

Attachment: patch #1 (ns tree - all platforms)

Comment 2

[Sean Su]

Attachment: patch #1 (moz tree - all platforms)

Comment 3

[Samir Gehani]

Nice hack!  Sorry to generate more work but can we make this a function call in
share.t used something along the lines:
platformNode = getPlatform();

where getPlatform() is defined as:
function getPlatform()
{
  if('platform' in Install)
  {
    platformStr = new String(Install.platform);
    if (!platformStr.search(/^Macintosh/))
      platformNode = 'mac';
    else if (!platformStr.search(/^Win/))
      platformNode = 'win';
    else
      platformNode = 'unix';
  }
  else
  {
    var fOSMac  = getFolder("Mac System");
    var fOSWin  = getFolder("Win System");
    var fOSUnix = getFolder("Unix Local");
    logComment("fOSMac: "  + fOSMac);
    logComment("fOSWin: "  + fOSWin);
    //  logComment("fOSUnix: " + fOSUnix); <-- XXX remove this; it is not used!
    if(fOSMac != null)
      platformNode = 'mac';
    else if(fOSWin != null)
      platformNode = 'win';
    else
      platformNode = 'unix';
  }

  return platformNode;
}

Comment 4

[Samir Gehani]

Oh, err, also remove this line since itis not used:
var fOSUnix = getFolder("Unix Local");

Comment 5

[Sean Su]

Attachment: patch #2 (ns tree)

Comment 6

[Sean Su]

Attachment: patch #2 (moz tree)

Comment 7

[Samir Gehani]

Nice!  r=sgehani

Comment 8

[Scott MacGregor]

rs = mscott

Comment 9

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for 0.9.2

Comment 10

[Sean Su]

fixed.

Comment 11

[Jimmy Lee]

Stray old bug.  Verified on all platforms.  It's updated.  Marking Verified.