langenus.xpi does not install properly when smartupdating

VERIFIED FIXED

Status

--
blocker
VERIFIED FIXED
18 years ago
11 years ago

People

(Reporter: ssu0262, Assigned: slogan)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: have patch, critical for 0.9.2, have r=,sr=,a=)

Attachments

(4 attachments)

(Reporter)

Description

18 years ago
When smartupdating from 6.0x -> 6.1b1, langenus.xpi will not correctly detect 
which OS it is running from.  This is because during this smartupdate scenario, 
the browser is version 6.0.  This version of the browser does not support 
'Install.platform', only 6.1b1 does.  This will cause the wrong file to be 
registered.

This is filed in bugzilla because langenus.xpi from mozilla also has the same 
problem, not necessarily with N6.0x, but with earlier versions of mozilla.

patches for both mozilla and ns on all platforms coming up.
(Reporter)

Updated

18 years ago
QA Contact: gbush → jimmylee
(Reporter)

Comment 1

18 years ago
Created attachment 38383 [details] [diff] [review]
patch #1 (ns tree - all platforms)
(Reporter)

Comment 2

18 years ago
Created attachment 38384 [details] [diff] [review]
patch #1 (moz tree - all platforms)
(Reporter)

Updated

18 years ago
Whiteboard: have patch;need r=,sr=,a=

Comment 3

18 years ago
Nice hack!  Sorry to generate more work but can we make this a function call in
share.t used something along the lines:
platformNode = getPlatform();

where getPlatform() is defined as:
function getPlatform()
{
  if('platform' in Install)
  {
    platformStr = new String(Install.platform);
    if (!platformStr.search(/^Macintosh/))
      platformNode = 'mac';
    else if (!platformStr.search(/^Win/))
      platformNode = 'win';
    else
      platformNode = 'unix';
  }
  else
  {
    var fOSMac  = getFolder("Mac System");
    var fOSWin  = getFolder("Win System");
    var fOSUnix = getFolder("Unix Local");
    logComment("fOSMac: "  + fOSMac);
    logComment("fOSWin: "  + fOSWin);
    //  logComment("fOSUnix: " + fOSUnix); <-- XXX remove this; it is not used!
    if(fOSMac != null)
      platformNode = 'mac';
    else if(fOSWin != null)
      platformNode = 'win';
    else
      platformNode = 'unix';
  }

  return platformNode;
}

Comment 4

18 years ago
Oh, err, also remove this line since itis not used:
var fOSUnix = getFolder("Unix Local");

(Reporter)

Comment 5

18 years ago
Created attachment 39621 [details] [diff] [review]
patch #2 (ns tree)
(Reporter)

Comment 6

18 years ago
Created attachment 39622 [details] [diff] [review]
patch #2 (moz tree)

Comment 7

18 years ago
Nice!  r=sgehani

Comment 8

18 years ago
rs = mscott
a=blizzard on behalf of drivers for 0.9.2
Whiteboard: have patch;need r=,sr=,a= → have patch, critical for 0.9.2, have r=,sr=,a=
(Reporter)

Comment 10

18 years ago
fixed.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
Stray old bug.  Verified on all platforms.  It's updated.  Marking Verified.
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey

Updated

11 years ago
Component: Installer: XPI Packages → Installer
QA Contact: jimmykenlee → general
You need to log in before you can comment on or make changes to this bug.