858674 - Tweak SQLite pragmas on mobile devices for space savings

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch for mozilla-central, v1

Bug 853350 requires a bunch of engineering and product work to fully resolve. In the short term we can tweak SQLite pragmas on mobile devices to get a little more space back when we delete things from indexedDB databases. We can also get a little speed boost by leaving 0-size .sqlite-journal files on disk rather than deleting them.

Attached patch requires the patches from bug 857376 to land, but that should be happening as soon as the tree reopens.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch for mozilla-b2g18, v1

This is nearly identical to the m-c patch, only real difference is that page_size is hardcoded since we decided not to do anything fancy on b2g18 in bug 858674.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Filed bug 858680 on figuring out a long-term solution involving full VACUUMs for indexedDB.

Comment 3

[Daniel Coloma:dcoloma]

Given that we don't have still any progress with bug 853350 I think landing this makes sense

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e01b8a81990

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for Windows bustage.
https://hg.mozilla.org/integration/mozilla-inbound/rev/99cfae75ee7c

https://tbpl.mozilla.org/php/getParsedLog.php?id=21556769&tree=Mozilla-Inbound

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0553df9a3be with r=khuey on the (tiny) change.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e0553df9a3be

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Your b2g18 patch is going to need updating for the Windows bustage too...

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch for mozilla-b2g18

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Updated patch for mozilla-b2g18.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/b876371dc011
https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/a5d3be0e028d