Editor helper min height and width can be circumvented

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
STR:

1. Add a popup track event.
2. Drag the width to be smaller than min.

Expected: It enforces the min width.

3. Now, try it again.

Expected: Still enforced.
Actual: Lets me make it smaller.

Seems if you resize something that's on the min, it is not enforced.
(Assignee)

Comment 1

6 years ago
So, probalem here is a track event with paremeters not being changed, does no tdo the update, thus it leaves the draggable div in whatever state jquery ui left it at.

The above patch simply assumes the update may not succeed, so it handles it itself, just in case.
Assignee: nobody → scott
Comment on attachment 734058 [details]
https://github.com/mozilla/butter/pull/1653

R+

Land it.
Attachment #734058 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 4

6 years ago
Staged: https://github.com/mozilla/butter/commit/9437b7b2a14b91953b04cc6a3a4e26e57767b411
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.