858776 - Browser about page links to FAQ URL using HTTPS

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P3)

Description

[Benjamin Kerensa [:bkerensa]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:19.0) Gecko/20100101 Firefox/19.0
Build ID: 20130308124351

Steps to reproduce:

Gaia Browser about page links to Firefox OS FAQ via a HTTPS URL even though its not needed and other url's use HTTP on the same page. 


Actual results:

HTTPS link is used


Expected results:

We should use HTTP like other links on the page:
1. HTTPS is not needed for the specific page
2. HTTPS uses more power on servers

Comment 1

[Benjamin Kerensa [:bkerensa]]

https://github.com/mozilla-b2g/gaia/pull/9022

Fix ^

Comment 2

[Dale Harvey (:daleharvey)]

Hey Benjamin

Thanks for the patch, few minor issues, could you make a single PR with the fix for just the browser, the commit message needs amended to follow the convention:

'Bug 858776 - Use http links in about page'

for example, then attach a patch here and set it to r? to me

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Gaia/Hacking#Submitting_a_patch has some more help about submitting patches

Thanks
Dale

Comment 3

[Dale Harvey (:daleharvey)]

Taking as I hadnt heard back

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Link to http faq page

Comment 5

[Ben Francis [:benfrancis]]

Comment on attachment 776992 [details] [review]
Link to http faq page

r+me

Comment 6

[ffos-browser]

Ben Francis changed story state to accepted in Pivotal Tracker

Comment 7

[Ben Francis [:benfrancis]]

Merged in https://github.com/mozilla-b2g/gaia/commit/f97547505a54153c454cee90e01ca4a58f9f5a03

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 892963 blocks verification on this for master.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Still blocked.  I don't crash on the system, I get the tab crashing with a this is embarassing now when going to about firefox.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

gecko : 27cd5f2dd44b576a8faabaab239fd3250ff8fef9
gaia : 4f8ffa9b3915a788477aa97197181feb26590fe8
build id : 2013-07-23-03-02-02

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
"gecko" revision="8c240c67f76c"
"gecko" revision="4dd254baf424523d3256ae47bdc20f9b2b8d5217"
"gaia" revision="b527d7406b4eed3bacdee78597bb4ff21bf9f7d0"
Build ID: 2013-08-13-04-02-22
MC/master build
Unagi

note: this page points to the Firefox for android; filing another bug.