The default bug view has changed. See this FAQ.

Switch-to-tab does not work on always private browsing mode

VERIFIED FIXED in Firefox 23

Status

()

Firefox
Private Browsing
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: tatsuya.sugi, Assigned: hardfire)

Tracking

20 Branch
Firefox 23
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox23 verified, firefox24 verified)

Details

(Whiteboard: [mentor=jdm][lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0
Build ID: 20130326150557

Steps to reproduce:

- Check "Always use private browsing mode".
- Restart FireFox.
- Open any URL.
- Open other tab and input the same URL.



Actual results:

- "Switch-to-tab" does not work, that is, duplicate the same URL.
Confirmed with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130406 Firefox/23.0 ID:20130406030922 CSet: 768af8d8fad4

Found no dupe.
Component: Untriaged → Private Browsing

Updated

4 years ago
Blocks: 816527
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

4 years ago
This bug can be fixed by looking at the patch in bug 816527 (which originally disabled this functionality for private windows) and adding checks for PrivateBrowsingUtils.permanentPrivateBrowsing in places that make sense.
Whiteboard: [mentor=jdm][lang=js]

Comment 3

4 years ago
I wants to work on this bug. I have prerequisite knowledge of  c,c++,javascript, Html and Css.
So please assign this to me.

Comment 4

4 years ago
Great! Please ask if anything is unclear.
Assignee: nobody → rahulgandhi38

Comment 5

4 years ago
I am new to development . so can you please help me and explain this bug.

Comment 6

4 years ago
Have you looked at the patch in bug 816527? That's the code that will need to be changed by adding the extra checks for permanent private browsing mode.

Comment 7

4 years ago
I have seen the patch but what kind of extra checks for permanent private browsing mode we have to add?

Comment 8

4 years ago
It looks like you'll want to add an extra condition in every check that was added in that patch.

Comment 9

4 years ago
Let's throw this back in the pool until you've finished the other work you're doing.
Assignee: rahulgandhi38 → nobody

Updated

4 years ago
Assignee: nobody → avinash
(Assignee)

Comment 10

4 years ago
Created attachment 740044 [details] [diff] [review]
patch for bug

Added the checks at the required places. I couldn't figure out how to write the tests, some help would be appreciated.
Attachment #740044 - Flags: review?(josh)
Hey Avinash, I see there are a couple of indentation nits to fix on a first glance.
(Assignee)

Comment 12

4 years ago
Created attachment 740148 [details] [diff] [review]
fixed indentation

fixed indentation.
Attachment #740044 - Attachment is obsolete: true
Attachment #740044 - Flags: review?(josh)
Attachment #740148 - Flags: review?(josh)
Comment on attachment 740148 [details] [diff] [review]
fixed indentation

Review of attachment 740148 [details] [diff] [review]:
-----------------------------------------------------------------

This looks like what I was expecting. Over to gavin, who knows the code better than me.
Attachment #740148 - Flags: review?(josh)
Attachment #740148 - Flags: review?(gavin.sharp)
Attachment #740148 - Flags: feedback+
Attachment #740148 - Flags: review?(gavin.sharp) → review?(bmcbride)
Comment on attachment 740148 [details] [diff] [review]
fixed indentation

Review of attachment 740148 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - thanks, Avinash!

AFAIK, we don't have a way to test UI changes for permanent private browsing mode - so you don't need to worry about that.
Attachment #740148 - Flags: review?(bmcbride) → review+
Landed on the fx-team branch, which will get merged into mozilla-central within a day or two:
https://hg.mozilla.org/integration/fx-team/rev/070edc4c07a6
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/070edc4c07a6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Verified as fixed on Windows 7, 64 bits, on Aurora 23.0 and latest Nightly 24.0:

- User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20130519 Firefox/23.0, Build ID: 20130519004019

- User agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:24.0) Gecko/20130519 Firefox/24.0, Build ID: 20130519031035
Status: RESOLVED → VERIFIED
status-firefox23: --- → verified
status-firefox24: --- → verified
You need to log in before you can comment on or make changes to this bug.