Closed Bug 858935 Opened 12 years ago Closed 12 years ago

Intermittent test-tabs.testOnPageShowEvent | Page was not cached after 5s (and 451 more)

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: jsantell)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

GH Pull Request 932
379 bytes, text/plain
Details
Pull request 934
165 bytes, text/html
Details
Interesting failure mode. https://tbpl.mozilla.org/php/getParsedLog.php?id=21505358&tree=Mozilla-Inbound Ubuntu VM 12.04 mozilla-inbound debug test jetpack on 2013-04-05 19:57:43 PDT for push f0063cd8a37b slave: tst-linux32-ec2-096 ... JavaScript strict warning: chrome://browser/content/abouthome/aboutHome.js, line 202: reference to undefined property localStorage[key] ++DOMWINDOW == 103 (0xd9743cc) [serial = 207] [outer = 0xbb031bc] TEST-UNEXPECTED-FAIL | tests/test-tabs.testOnPageShowEvent | Page was not cached after 5s TEST-INFO | Traceback (most recent call last): File "resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js", line 114, in _onPageShow this._emit(EVENTS.pageshow.name, this._public, event.persisted); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 123, in _emit return this._emitOnObject.apply(this, args); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 153, in _emitOnObject listener.apply(targetObj, params); File "resource://gre/modules/commonjs/sdk/windows/tabs-firefox.js", line 128, in _emitEvent tabs._emit.apply(tabs, args); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 123, in _emit return this._emitOnObject.apply(this, args); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 153, in _emitOnObject listener.apply(targetObj, params); File "resource://extensions.modules.ecabadbd-21a8-4a30-8ba5-748ed87636c1-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 1056, in setup test.fail('Page was not cached after 5s') File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail this.console.testMessage(false, false, this.test.name, message); File "resource://gre/modules/commonjs/sdk/test/harness.js", line 380, in testMessage this.trace(); TEST-END | tests/test-tabs.testOnPageShowEvent WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 WARNING: NS_ENSURE_SUCCESS(rv, false) failed with result 0x8000FFFF: file ../../../../content/base/src/nsContentUtils.cpp, line 3076 WARNING: NS_ENSURE_TRUE(pusher.Push(aBoundElement)) failed: file ../../../../content/xbl/src/nsXBLProtoImplMethod.cpp, line 315 TEST-START | tests/test-tabs.testOpen ++DOCSHELL 0x13fe9018 == 34 [id = 86] ++DOMWINDOW == 104 (0xe637c2c) [serial = 208] [outer = (nil)] ++DOMWINDOW == 105 (0xe09bf0c) [serial = 209] [outer = 0xe637c2c] ++DOCSHELL 0xbb03ba8 == 35 [id = 87] ++DOMWINDOW == 106 (0x1161b5dc) [serial = 210] [outer = (nil)] ++DOCSHELL 0x13275880 == 36 [id = 88] ++DOMWINDOW == 107 (0xce8a61c) [serial = 211] [outer = (nil)] ++DOCSHELL 0xd5ae828 == 37 [id = 89] ++DOMWINDOW == 108 (0x124c9644) [serial = 212] [outer = (nil)] ++DOMWINDOW == 109 (0xe24d5ac) [serial = 213] [outer = 0x124c9644] WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv) && subjPrincipal) failed: file ../../../docshell/base/nsDocShell.cpp, line 8387 WARNING: OpenGL-accelerated layers are not supported on this system: file ../../../widget/xpwidgets/nsBaseWidget.cpp, line 849 WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2388 ++DOMWINDOW == 110 (0xe7d15bc) [serial = 214] [outer = 0x1161b5dc] WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2388 ++DOMWINDOW == 111 (0xd0c6844) [serial = 215] [outer = 0xce8a61c] ++DOMWINDOW == 112 (0xdf50a34) [serial = 216] [outer = 0x124c9644] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265 JavaScript error: chrome://browser/content/urlbarBindings.xml, line 642: aUrl is undefined ++DOCSHELL 0xd1484d8 == 38 [id = 90] ++DOMWINDOW == 113 (0x108e1124) [serial = 217] [outer = (nil)] ++DOMWINDOW == 114 (0xfa5c374) [serial = 218] [outer = 0x108e1124] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265 WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 265 TEST-PASS | tests/test-tabs.testOpen | URL of the new tab matches TEST-PASS | tests/test-tabs.testOpen | URL of active tab in the current window matches TEST-PASS | tests/test-tabs.testOpen | The new tab is not pinned TEST-UNEXPECTED-FAIL | tests/test-tabs.testOpen | Page was not cached after 5s TEST-INFO | Traceback (most recent call last): File "resource://gre/modules/commonjs/sdk/tabs/tab-firefox.js", line 114, in _onPageShow this._emit(EVENTS.pageshow.name, this._public, event.persisted); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 123, in _emit return this._emitOnObject.apply(this, args); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 153, in _emitOnObject listener.apply(targetObj, params); File "resource://gre/modules/commonjs/sdk/windows/tabs-firefox.js", line 128, in _emitEvent tabs._emit.apply(tabs, args); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 123, in _emit return this._emitOnObject.apply(this, args); File "resource://gre/modules/commonjs/sdk/deprecated/events.js", line 153, in _emitOnObject listener.apply(targetObj, params); File "resource://extensions.modules.ecabadbd-21a8-4a30-8ba5-748ed87636c1-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 1056, in setup test.fail('Page was not cached after 5s') File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail this.console.testMessage(false, false, this.test.name, message); File "resource://gre/modules/commonjs/sdk/test/harness.js", line 380, in testMessage this.trace(); TEST-END | tests/test-tabs.testOpen ... First 100 of 452 failures shown.
Matteo can you take a look at this one ?
Assignee: nobody → zer0
Actually I just recalled this was done by Jordan and he had some issues with it. So it's more reasonable to ask him to dig into this.
Assignee: zer0 → jsantell
This is looking like perma-fail on OSX opt builds at the moment.
And magically it's working again. Smells like touching external network resources...
This test is testing too much, I think -- the pageshow event is fired on every page load, and that's able to be tested fine, but to determine if the page is loaded from cache with pageshow requires waiting for the page to be cached (and there's no event or way to determine if the page has been 'sat on' long enough to be cached), so it attempts after waiting 500ms, then 1000ms, 2000ms, 4000ms and then fails at that point. Adding a test for checking pageshow is working, minus the persistence component until we can test in a way that doesn't rely on timers
Attached file GH Pull Request 932 —
Attachment #735896 - Flags: review?(zer0)
Attached file Pull request 934 —
Jason, wouldn't it be because of the URL about:home/about:newtab that are special? I haven't been able to see issues with persisted with this test... Is my computer running too fast? Would it only happen on tbpl?
Attachment #736007 - Flags: feedback?(jsantell)
Yeah, this is something that doesn't occur on dev machines, only on tbpl :[
Alex, that change could work -- the about:home/about:newtab URLs didn't seem to be any different for me locally, as they could still be loaded from cache, but maybe the data URIs will be much faster regardless (probably so). I sent a PR for this guy to remove the persistence test (and just test pageshow event working separate from persistence), and then created a new bug 860394 for testing persistence -- do you want to see if your PR using data URIs does the trick? Crossing fingers :)
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d3734e80ad8a97a8321689ad1e4102179b7c8dda Bug 858935 - Intermittent test-tabs.testOnPageShowEvent | Page was not cached after 5s https://github.com/mozilla/addon-sdk/commit/51709bc94082f3dd4acda8c953abafa17e04945c Merge pull request #934 from ochameau/bug858935 fix Bug 858935 - Intermittent test-tabs.testOnPageShowEvent | Page was not cached after 5s, a=@ochameau
Phil, we've merged Alex's updated tests and no longer depends on a timer and passed on a stripped down VM so hopefully this isn't an issue anymore. If it is, please let us know!
Flags: needinfo?(philringnalda)
Well, except I'll continue letting you know about old things until the next uplift, and it'll be KWierso who will let you know if it happens on the jetpack tree between now and when it hits m-i.
Flags: needinfo?(philringnalda)
Attachment #736007 - Flags: feedback?(jsantell)
Commits pushed to integration at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d3734e80ad8a97a8321689ad1e4102179b7c8dda Bug 858935 - Intermittent test-tabs.testOnPageShowEvent | Page was not cached after 5s https://github.com/mozilla/addon-sdk/commit/51709bc94082f3dd4acda8c953abafa17e04945c Merge pull request #934 from ochameau/bug858935
Attachment #735896 - Flags: review?(zer0)
Looks fixed to me.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: