Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: kohei, Assigned: marsf)

Tracking

({productization})

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(2 attachments, 2 obsolete attachments)

Yahoo!オークション has been renamed to ヤフオク! The bundled search engine should be updated to reflect the change.
Summary: [ja] Rename Yahoo! Auction → [ja] Rename Yahoo! Auctions
Assignee: nobody → chimantaea_mirabilis
Status: NEW → ASSIGNED
Assignee

Comment 1

6 years ago
Posted patch rename for browser (obsolete) — Splinter Review
Attachment #738555 - Flags: review?
Assignee

Comment 2

6 years ago
Posted patch rename for mail (obsolete) — Splinter Review
Attachment #738556 - Flags: review?
Assignee

Comment 3

6 years ago
Yoshino-san:
Who can review this renaming in Japanese? or r+ myself?
Dunno, but your patches look good to me :)
Comment on attachment 738555 [details] [diff] [review]
rename for browser

Review of attachment 738555 [details] [diff] [review]:
-----------------------------------------------------------------

Hey, I can review this :-)

Sadly, I'll need to send you an r-. For Japanese, we're ordering all search engines, so you'll need to adjust the changed name in region.properties as well.

I'd recommend doing the same for mail, but the sorting there is broken because you're not having the added prefs in mail/all-l10n.js. I'd suggest Standard8 as a reviewer for that patch.
Attachment #738555 - Flags: review? → review-
Assignee

Comment 6

6 years ago
I've just forgotten about the item in region.properties.
Thanks Axel.
Attachment #738555 - Attachment is obsolete: true
Attachment #739531 - Flags: review?(l10n)
Assignee

Comment 7

6 years ago
Attachment #738556 - Attachment is obsolete: true
Attachment #738556 - Flags: review?
Attachment #739533 - Flags: review?(mbanner)
Comment on attachment 739531 [details] [diff] [review]
rename for browser

Review of attachment 739531 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, please land this with a check-in comment referencing this bug and my review.
Attachment #739531 - Flags: review?(l10n) → review+
Tested with Firefox 21.0b6 build1 ja-JP-mac.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Comment on attachment 739533 [details] [diff] [review]
rename for mail

Sorry for the delay, looks good.
Attachment #739533 - Flags: review?(mbanner) → review+
(In reply to Kohei Yoshino from comment #11)
> Tested with Firefox 21.0b6 build1 ja-JP-mac.

and win32 ja.
You need to log in before you can comment on or make changes to this bug.