858960 - java.lang.NullPointerException: at java.util.regex.Matcher.reset(Matcher.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It first showed up in 22.0a1/20130327.

Here is a crash report: bp-c52c326f-cad6-42ce-80b3-3c1222130406.

java.lang.NullPointerException
	at java.util.regex.Matcher.reset(Matcher.java:181)
	at java.util.regex.Matcher.<init>(Matcher.java:94)
	at java.util.regex.Pattern.matcher(Pattern.java:290)
	at org.mozilla.gecko.ANRReporter.isGeckoTraces(ANRReporter.java:225)
	at org.mozilla.gecko.ANRReporter.onReceive(ANRReporter.java:579)
	at android.app.LoadedApk$ReceiverDispatcher$Args.run(LoadedApk.java:728)
	at android.os.Handler.handleCallback(Handler.java:605)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at org.mozilla.gecko.ANRReporter$1.run(ANRReporter.java:102)
	at java.lang.Thread.run(Thread.java:856)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.NullPointerException%3A+at+java.util.regex.Matcher.reset%28Matcher.java%29

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Check for end of stream when identifying traces file (v1)

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d7e1a76c63d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d7e1a76c63d

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 734757 [details] [diff] [review]
Check for end of stream when identifying traces file (v1)

[Approval Request Comment]

Bug caused by (feature/regressing bug #): N/A

User impact if declined: Crash when the App Not Responding dialog appears in Fennec

Testing completed (on m-c, etc.): Locally, m-c

Risk to taking this patch (and alternatives if risky): Very small; patch only fixes the crash case

String or IDL/UUID changes made by this patch: None

Comment 5

[Alex Keybl [:akeybl]]

(In reply to Jim Chen [:jchen :nchen] from comment #4)
> Bug caused by (feature/regressing bug #): N/A

Hard to believe this is n/a - 21 was unaffected.

> User impact if declined: Crash when the App Not Responding dialog appears in
> Fennec

Have we confirmed that the crash volume fell off on Nightly? I don't see STR here that could have been verified.

Comment 6

[bhavana bajaj [:bajaj]]

setting need-info, on jim to help with comment# 5.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Alex Keybl [:akeybl] from comment #5)
> (In reply to Jim Chen [:jchen :nchen] from comment #4)
> > Bug caused by (feature/regressing bug #): N/A
> 
> Hard to believe this is n/a - 21 was unaffected.

Sorry, the crash was caused by the ANR feature introduced in 22 (tracking bug 833990) 

> > User impact if declined: Crash when the App Not Responding dialog appears in
> > Fennec
> 
> Have we confirmed that the crash volume fell off on Nightly? I don't see STR
> here that could have been verified.

Yes, the crash volume has gone to zero. There were 12 crash reports before the fix landed, and none since then.

Thanks!

Comment 8

[bhavana bajaj [:bajaj]]

Comment on attachment 734757 [details] [diff] [review]
Check for end of stream when identifying traces file (v1)

low risk, Fx 22 regression.Approving for uplift.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5a363da6e4ff