Closed
Bug 858993
Opened 8 years ago
Closed 7 years ago
mark unused folder flags in nsMsgFolderFlags.idl
Categories
(MailNews Core :: Database, defect)
MailNews Core
Database
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 28.0
People
(Reporter: aceman, Assigned: aceman)
References
()
Details
Attachments
(1 file)
4.08 KB,
patch
|
rkent
:
review+
neil
:
review+
|
Details | Diff | Splinter Review |
There are some folder flags in nsMsgFolderFlags.idl that are unused in current code base. We could mark those to avoid confusion. There are already some Unused* flags in the file. - NewsHost seems unused. - Subscribed seems unused. - ImapServer seems unused. - CreatedOffline is queried but never set. Can anybody check if any extensions use these? If not, can we rename these to Unused* as the current style in the file is?
Comment 1•8 years ago
|
||
There are no AMO addons that reference nsMsgFolderFlags.X where X = NewsHost, Subscribed, ImapServer, or CreatedOffline
Attachment #780524 -
Flags: review?(neil)
Attachment #780524 -
Flags: review?(kent)
Comment 4•8 years ago
|
||
Comment on attachment 780524 [details] [diff] [review] patch Well, it compiles, so I guess the flags are unused in C++ at least...
Attachment #780524 -
Flags: review?(neil) → review+
Comment 5•7 years ago
|
||
Comment on attachment 780524 [details] [diff] [review] patch Sorry for the slow review. Looks good.
Attachment #780524 -
Flags: review?(kent) → review+
Comment 7•7 years ago
|
||
https://hg.mozilla.org/comm-central/rev/6ddc5aea7641
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 28.0
Comment 8•7 years ago
|
||
Comment on attachment 780524 [details] [diff] [review] patch Review of attachment 780524 [details] [diff] [review]: ----------------------------------------------------------------- ::: mailnews/base/public/nsMsgFolderFlags.idl @@ +88,5 @@ > const nsMsgFolderFlagType PersonalShared = 0x00800000; > /// This folder is an IMAP \\Noselect folder > const nsMsgFolderFlagType ImapNoselect = 0x01000000; > + /// This folder created offline (this is never set in current code, > + /// but it is still checked for and obeyed if found on a folder. Nit: Missing closing brace ;)
You need to log in
before you can comment on or make changes to this bug.
Description
•