858993 - mark unused folder flags in nsMsgFolderFlags.idl

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[:aceman]

There are some folder flags in nsMsgFolderFlags.idl that are unused in current code base. We could mark those to avoid confusion. There are already some Unused* flags in the file.

- NewsHost seems unused.
- Subscribed seems unused.
- ImapServer seems unused.
- CreatedOffline is queried but never set.

Can anybody check if any extensions use these?
If not, can we rename these to Unused* as the current style in the file is?

Comment 1

[Kent James (:rkent)]

There are no AMO addons that reference nsMsgFolderFlags.X where X = NewsHost, Subscribed, ImapServer, or CreatedOffline

Comment 2

[:aceman]

Thanks.

Comment 3

[:aceman]

Attachment: patch

Comment 4

[[e-mail]]

Comment on attachment 780524 [details] [diff] [review]
patch

Well, it compiles, so I guess the flags are unused in C++ at least...

Comment 5

[Kent James (:rkent)]

Comment on attachment 780524 [details] [diff] [review]
patch

Sorry for the slow review. Looks good.

Comment 6

[:aceman]

Thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/6ddc5aea7641

Comment 8

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 780524 [details] [diff] [review]
patch

Review of attachment 780524 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/public/nsMsgFolderFlags.idl
@@ +88,5 @@
>    const nsMsgFolderFlagType PersonalShared  = 0x00800000;
>    /// This folder is an IMAP \\Noselect folder
>    const nsMsgFolderFlagType ImapNoselect    = 0x01000000;
> +  /// This folder created offline (this is never set in current code,
> +  /// but it is still checked for and obeyed if found on a folder.

Nit: Missing closing brace ;)