858996 - Cannot open file contain '~' in file name via DeviceStorage API

Status: RESOLVED DUPLICATE of bug 845707

(Firefox OS Graveyard :: General, defect)

Description

[leo.bugzilla.gecko]

When I push attached video clip in the device, video application can retrieve thumbnail.
However, if I try to play the contents, it cannot play the clip.

nsresult nsHTMLMediaElement::InitializeDecoderForChannel(nsIChannel *aChannel,
                                                         nsIStreamListener **aListener)
{
    aChannel->GetContentType(mMimeType); <==== this function returns strange mimetype.
}

It returns mimetype of "text/html"
I think this problem is related to file name of the video clip.

And there's log like this.
01-07 22:14:39.009 E       459      GeckoConsole                 Content JS ERROR at app://video.gaiamobile.org/gaia_build_defer_index.js:140 in anonymous: MediaDB.getFile: SecurityError

Comment 1

[leo.bugzilla.gecko]

I cannot attach file. (Becuase file name is the problem)
Please check this issue with any file that's renamed like this ")(&%$#@!~_+-=.png.mp4"

Comment 2

[Wayne Chang [:wchang]]

Triage 4/10 - Leo- base on comment 1, a weird file name would cause this. Which should not be a proper use case.

Tim, can you suggest someone that can check this issue?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Web content has nothing to do with mine-type. Logic in Gecko must have been cause this issue.

Comment 4

[Kan-Ru Chen [:kanru] (UTC+9)]

If I recall correctly, we sniff the content type based on the file data instead of the file name so unless the data is incorrect we shouldn't get "text/html".

Comment 5

[Paul Adenot (:padenot)]

Yes, we do. Please upload the file somewhere so I can check what is going on here.

Comment 6

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Using any mp4 video and rename it to ")(&%$#@!~_+-=.png.mp4" will reproduce this bug. The mimetype |text/html| is generated for about:blank, not for the video file. It's most likely that we are not encoding the URL for the special file path correctly.

Here is the actual error log:
> E/GeckoConsole( 1300): [JavaScript Warning: "HTTP "Content-Type" of "text/html" is not supported. Load of media resource about:blank failed." {file: "app://video.gaiamobile.org/index.html" line: 0}]

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Urh, let's forget about the JS warning about Content-Type, this warning is actually pop-up at the first time you initiate the video player.

> E/GeckoConsole( 1300): Content JS ERROR at app://video.gaiamobile.org/shared/js/mediadb.js:594 in getFile/getRequest.onerror: MediaDB.getFile: SecurityError
The special file name contains the '~' character which will be concider as an unsafe file path in DeviceStorage, therefore an permission denied error will be raised.
http://dxr.mozilla.org/mozilla-central/dom/devicestorage/nsDeviceStorage.cpp#l2026

Comment 8

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The real issue here is that DeviceStorage cannot open a file which DeviceStorage reported to app previously. We should either allow the file open operation or not report its existance.

Comment 9

[Jason Smith [:jsmith]]

Dupe.

Comment 10

[leo.bugzilla.gecko]

Because leo? tag is removed from the bug 845707, I reopened this issue.

If you think this problem is not blocking issue, I want to solve this problem by another way.

This issue leads two problem on the device.
1. Video thumbnail is shown on video app but it cannot be played. (music and gallery application have same problem)
2. Since video application doesn't consider errors, device freezed after trying to play these kind of video clip.

So I think, those application should not list up the contents that have '~' character in its file name.

Comment 11

[Jason Smith [:jsmith]]

If there is no leo? tag on the other bug, the nom the dupe. But don't duplicate both as one being a nom and the other not being. There's discussion in the other bug as for why this was marked as a tracking-.