If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the MSVC exemption for FAIL_ON_WARNINGS in gfx/thebes

NEW
Unassigned

Status

()

Core
Graphics: Text
5 years ago
5 years ago

People

(Reporter: emk, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Created attachment 734322 [details] [diff] [review]
patch
Attachment #734322 - Flags: review?(jfkthame)
(Reporter)

Comment 1

5 years ago
Comment on attachment 734322 [details] [diff] [review]
patch

Build failed with the following error because we are overriding the "free" function using the infamous macro. It's really hard to work around the problem...

 0:38.88 h:\m\mozilla-central\obj-i686-pc-mingw32\dist\include\skia\SkTypes.h(39
6) : error C2220: 警告をエラーとして扱いました。'object' ファイルは生成されませ
ん。
 0:38.88
 0:38.88 Warning: C4003 in h:\m\mozilla-central\obj-i686-pc-mingw32\dist\include
\skia\SkTypes.h: マクロ 'free' に指定された実引数の数が少なすぎます。
 0:38.89 h:\m\mozilla-central\obj-i686-pc-mingw32\dist\include\skia\SkTypes.h(39
6) : warning C4003: マクロ 'free' に指定された実引数の数が少なすぎます。
 0:38.89
Attachment #734322 - Flags: review?(jfkthame)
You need to log in before you can comment on or make changes to this bug.