859020 - Remove the MSVC exemption for FAIL_ON_WARNINGS in dom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 1

[Mounir Lamouri (:mounir)]

Comment on attachment 734323 [details] [diff] [review]
patch

Review of attachment 734323 [details] [diff] [review]:
-----------------------------------------------------------------

A bit sad that we have to add a description for every MOZ_NOT_REACHED...

::: dom/indexedDB/Key.cpp
@@ +392,5 @@
>  
>    Float64Union pun;
>    pun.d = aFloat;
>    uint64_t number = pun.u & PR_UINT64(0x8000000000000000) ?
> +                    0 - pun.u :

Why do you need to add 0?

@@ +417,5 @@
>  
>    Float64Union pun;
>    pun.u = number & PR_UINT64(0x8000000000000000) ?
>            (number & ~PR_UINT64(0x8000000000000000)) :
> +          0 - number;

ditto

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Mounir Lamouri (:mounir) from comment #1)
> ::: dom/indexedDB/Key.cpp
> @@ +392,5 @@
> >  
> >    Float64Union pun;
> >    pun.d = aFloat;
> >    uint64_t number = pun.u & PR_UINT64(0x8000000000000000) ?
> > +                    0 - pun.u :
> 
> Why do you need to add 0?

MSVC is complaining about negating an unsigned value. See bug 859021 for details. I'll add a comment about that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 734323 [details] [diff] [review]
patch

>+                    0 - pun.u :

Please parenthesize that as (0 - pun.u)

>+          0 - number;

Likewise.

r=me

Comment 4

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da58003e7959

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/da58003e7959