Closed Bug 859020 Opened 7 years ago Closed 7 years ago

Remove the MSVC exemption for FAIL_ON_WARNINGS in dom

Categories

(Core :: DOM: Core & HTML, defect)

All
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #734323 - Flags: review?(bzbarsky)
Comment on attachment 734323 [details] [diff] [review]
patch

Review of attachment 734323 [details] [diff] [review]:
-----------------------------------------------------------------

A bit sad that we have to add a description for every MOZ_NOT_REACHED...

::: dom/indexedDB/Key.cpp
@@ +392,5 @@
>  
>    Float64Union pun;
>    pun.d = aFloat;
>    uint64_t number = pun.u & PR_UINT64(0x8000000000000000) ?
> +                    0 - pun.u :

Why do you need to add 0?

@@ +417,5 @@
>  
>    Float64Union pun;
>    pun.u = number & PR_UINT64(0x8000000000000000) ?
>            (number & ~PR_UINT64(0x8000000000000000)) :
> +          0 - number;

ditto
(In reply to Mounir Lamouri (:mounir) from comment #1)
> ::: dom/indexedDB/Key.cpp
> @@ +392,5 @@
> >  
> >    Float64Union pun;
> >    pun.d = aFloat;
> >    uint64_t number = pun.u & PR_UINT64(0x8000000000000000) ?
> > +                    0 - pun.u :
> 
> Why do you need to add 0?

MSVC is complaining about negating an unsigned value. See bug 859021 for details. I'll add a comment about that.
Comment on attachment 734323 [details] [diff] [review]
patch

>+                    0 - pun.u :

Please parenthesize that as (0 - pun.u)

>+          0 - number;

Likewise.

r=me
Attachment #734323 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/da58003e7959
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/da58003e7959
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.