Closed Bug 859024 Opened 8 years ago Closed 8 years ago

Remove the MSVC exemption for FAIL_ON_WARNINGS in content/canvas/src

Categories

(Core :: Canvas: 2D, defect)

All
Windows 8
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: emk, Assigned: emk)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
No description provided.
Attachment #734327 - Flags: review?(jmuizelaar)
(In reply to Masatoshi Kimura [:emk] from comment #0)
> Created attachment 734327 [details] [diff] [review]
> patch

What warning does this fix?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> What warning does this fix?

"C4146: unary minus operator applied to unsigned type, result still unsigned". See 859021 for details. I'll add a comment as I did in the bug.
Comment on attachment 734327 [details] [diff] [review]
patch

Review of attachment 734327 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.cpp
@@ +358,5 @@
>      uint8_t* dstStart = dst;
>      ptrdiff_t signedDstStride = dstStride;
>      if (mPixelStoreFlipY) {
>          dstStart = dst + (height - 1) * dstStride;
> +        signedDstStride = 0 - dstStride;

How about making this:
signedDstStride = -signedDstStride
instead.
Attachment #734327 - Flags: review?(jmuizelaar) → review-
Attached patch patch v2Splinter Review
Assignee: nobody → VYV03354
Attachment #734327 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #740018 - Flags: review?(jmuizelaar)
Attachment #740018 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/5597242cf580
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.