Remove the MSVC exemption for FAIL_ON_WARNINGS in content/canvas/src

RESOLVED FIXED in mozilla23

Status

()

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla23
All
Windows 8
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch patch (obsolete) — Splinter Review
No description provided.
Attachment #734327 - Flags: review?(jmuizelaar)
(In reply to Masatoshi Kimura [:emk] from comment #0)
> Created attachment 734327 [details] [diff] [review]
> patch

What warning does this fix?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> What warning does this fix?

"C4146: unary minus operator applied to unsigned type, result still unsigned". See 859021 for details. I'll add a comment as I did in the bug.
Comment on attachment 734327 [details] [diff] [review]
patch

Review of attachment 734327 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.cpp
@@ +358,5 @@
>      uint8_t* dstStart = dst;
>      ptrdiff_t signedDstStride = dstStride;
>      if (mPixelStoreFlipY) {
>          dstStart = dst + (height - 1) * dstStride;
> +        signedDstStride = 0 - dstStride;

How about making this:
signedDstStride = -signedDstStride
instead.
Attachment #734327 - Flags: review?(jmuizelaar) → review-
Posted patch patch v2Splinter Review
Assignee: nobody → VYV03354
Attachment #734327 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #740018 - Flags: review?(jmuizelaar)
Attachment #740018 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/5597242cf580
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.