859024 - Remove the MSVC exemption for FAIL_ON_WARNINGS in content/canvas/src

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 1

[Jeff Muizelaar [:jrmuizel]]

(In reply to Masatoshi Kimura [:emk] from comment #0)
> Created attachment 734327 [details] [diff] [review]
> patch

What warning does this fix?

Comment 2

[Masatoshi Kimura [:emk]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #1)
> What warning does this fix?

"C4146: unary minus operator applied to unsigned type, result still unsigned". See 859021 for details. I'll add a comment as I did in the bug.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 734327 [details] [diff] [review]
patch

Review of attachment 734327 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLTexelConversions.cpp
@@ +358,5 @@
>      uint8_t* dstStart = dst;
>      ptrdiff_t signedDstStride = dstStride;
>      if (mPixelStoreFlipY) {
>          dstStart = dst + (height - 1) * dstStride;
> +        signedDstStride = 0 - dstStride;

How about making this:
signedDstStride = -signedDstStride
instead.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: patch v2

Comment 5

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5597242cf580

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5597242cf580